Fixed #469 Added requireAccessToken() method to senders

[danielmorell]

Description of the change

We have three different built in payload senders that take a payload and send it to the Rollbar service. Some require that the payload include the access token. The Rollbar\Senders\CurlSender class is one of these. Our other two built in senders can use an external access token. The Rollbar\Senders\FluentSender is does not need the access token. And it was causing issues (see #469).

This proposed change moves the requirement for knowing if the access token is required from the Rollbar/Config class to the configured sender. All senders must implement Rollbar\Senders\SenderInterface. So, I added a new requireAccessToken() method to the SenderInterface. The method returns a boolean indicating if the sender requires the access token. This method is called during the initialization process. If the access token is required and not valid an error is thrown.

The reason this is a breaking change is because it requires the requireAccessToken() method be added to all custom sender interfaces.

An argument could be made that the Rollbar\Senders\AgentSender does not require the access token. For now, I am going to stick with the conclusion from #405, and leave it the way it is.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Maintenance
• New release

Related issues

• Fix Access token is required even if handler configuration parameter is set #469

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests
• All tests related to the changed code pass in development

Code review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
• "Ready for review" label attached to the PR and reviewers assigned
• Issue from task tracker has a link to this pull request
• Changes have been reviewed by at least one other engineer

[waltjones]

👍