Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHP 8.4 deprecations. #641

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fixed PHP 8.4 deprecations. #641

merged 2 commits into from
Dec 13, 2024

Conversation

basmilius
Copy link
Contributor

Description of the change

A few deprecation warnigns were raised as of PHP 8.4 in Rollbar. Namely the usage of E_STRICT (which was unused before 8.4) and implicitly marking nullable parameters as null. I've simply removed the usages of E_STRICT and added null types where they were missing.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Explicitly mark nullable parameters as null.
@danielmorell danielmorell self-requested a review December 6, 2024 17:38
@danielmorell danielmorell self-assigned this Dec 6, 2024
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basmilius Thank you for your work on this! This looks good.

@danielmorell danielmorell merged commit 7a1799f into rollbar:master Dec 13, 2024
@danielmorell danielmorell added this to the v4.1.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants