Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added telemetry config filter to prevent invalid arguments. #642

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This adds a filter to ensure no invalid arguments are passed to the Telemeter constructor. In the case of a framework needing additional configuration options for telemetry, we need to keep those config options from being sent to the core Telemeter constructor

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@danielmorell danielmorell merged commit 7cfdb3b into master Dec 13, 2024
@danielmorell danielmorell deleted the added/telemetry-config-filter branch December 13, 2024 23:26
@danielmorell danielmorell added this to the v4.1.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants