Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ignoredMessages type definition. #1028

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update ignoredMessages type definition. #1028

merged 1 commit into from
Nov 30, 2022
+1 −1

Conversation

sakai-akinobu
Copy link
Contributor

@sakai-akinobu sakai-akinobu commented May 19, 2022 •
edited
Loading

Description of the change

According to the documentation, it is possible to give regular expressions for ignoredMessages. However, this option was typed as string[].

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

waltjones
waltjones approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakai-akinobu thank you for the PR!

@waltjones waltjones merged commit 6a7c416 into rollbar:master Nov 30, 2022
@renovate renovate bot mentioned this pull request Dec 7, 2022
Merged
1 task
@waltjones waltjones mentioned this pull request Jan 4, 2023
Merged
7 tasks
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@sakai-akinobu
Update ignoredMessages type definition. (#1028)
c8a70d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakai-akinobu @waltjones