[Fixes #269] get rid of rollbar wrapper stack frames #335
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
Jul 11, 2017
src/browser/transforms.js
Outdated
| @@ -172,6 +172,9 @@ function addBodyTrace(item, options, callback) { | |||
| method: (!stackFrame.func || stackFrame.func === '?') ? '[anonymous]' : stackFrame.func, | |||
| colno: stackFrame.column | |||
| }; | |||
| if (frame.method && frame.method.indexOf('f._wrapped') != -1) { | |||
There was a problem hiding this comment.
This seems fragile - it might break if:
- this library changes, so the minified frame is no longer called
f._wrapped - this library is included in a larger application build, and the minified name there is something else
How about if we change the _wrapped part to be more identifiable? e.g. _rollbar_wrapped -- and then we can just check that the method name ends with the exact string ._rollbar_wrapped
|
👍 Will this require people to update their snippet? |
|
Yeah, the snippet will change |
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
[Fixes #269] get rid of rollbar wrapper stack frames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrap certain built-ins in the browser and rethrow exceptions. When such an error occurs, our wrapper ends up in the stack trace because technically it is running, but it isn't really part of the error so there is no reason for it to be in the stack trace.
There are a few different ways I looked at fixing this, but in the end just checking for our
f._wrappedmethod signature in the frame is the simplest and actually works about as well as any other approach. Threading state around is a bit of a mess, and actually munging the exception at the rethrow site is impossible due to browser differences.