Recover from read-only window.console object #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltjones
force-pushed
the
wj-console-getter-only
branch
from
65f50e9
to
9c1b07e
Compare
1 task
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Recover from read-only window.console object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #751
In some environments, the console methods (e.g.
log,debug, etc.) have been replaced with read-only properties. No known browsers do this by default, but it appears that other code running in the browser replaces or modifieswindow.consoleto use read-only properties. (See examples here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Getter_only)In strict mode code environments, Rollbar will then fail with
TypeError: setting getter-only property "debug". In non strict mode environments, Rollbar will silently fail to update the console methods.This fix sets strict mode while updating the console methods. This ensures a consistent and predictable behavior across different code environments, and allows Rollbar to record a diagnostic message in cases where it might have silently failed before.
NOTE: This PR also includes a commit to reset telemetry hooks between tests. Otherwise, telemetry related tests can't work correctly.