-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add namespace / appID as optional parameter to Submit function #33
Comments
From our quick with @distractedm1nd we decided to look into embedding namespaces into IDs. You could make it part of the interface via options, but that leaks the abstraction, as only some DA have namespaces. I believe the original idea for such an edge cases was to embed such data in implementation-specific IDs |
IDs are posted on-chain so I would keep that as minimal as possible. I would give more options to submit. In the future, there could be even more preferences encoded in those options like priority, top of block, TTL, etc, which not every DA-Layer has. Is see Namespace just as one of those preferences. |
|
However there is no way to pass ID to submit right now. It only accepts alias to bytes which is Blob type. This is very limiting and in order to make the abstraction completer, the Blob type would need to be promoted to interface with ID method. This is though for a later refactoring. |
I contemplated the following options:
DA layers dont need to support namespaces of course, but it will also be good for the avail impl for example |
Implementation ideas
In order to implement go-da directly into celestia-node, setting namespace as a global parameter is not a viable option. Additionally, it restricts the possibility for clients to use multiple namespaces without instantiating multiple clients. To fix this, we can add a field
SubmitOptions
to the Submit signature.The text was updated successfully, but these errors were encountered: