-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
da: replace submit options with gas price #31
Conversation
Warning Rate Limit Exceeded@tuxcanfly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 10 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe codebase has undergone a significant change where the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 75.51% 79.31% +3.80%
==========================================
Files 4 3 -1
Lines 196 174 -22
==========================================
- Hits 148 138 -10
+ Misses 39 28 -11
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- types/pb/da/da.pb.go
Files selected for processing (7)
- da.go (1 hunks)
- proto/da/da.proto (1 hunks)
- proxy/client.go (1 hunks)
- proxy/server.go (1 hunks)
- proxy/util.go (1 hunks)
- test/dummy.go (1 hunks)
- test/test_suite.go (3 hunks)
Additional comments: 7
proxy/util.go (2)
- 21-26: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-39]
The removal of
optionsDA2PB
andoptionsPB2DA
functions aligns with the PR's objective to simplify the gas pricing model. Ensure that there are no remaining references to these functions elsewhere in the codebase.Verification successful
The executed script did not find any references to the removed functions
optionsDA2PB
oroptionsPB2DA
in the Go files of the codebase. This suggests that these functions have been successfully removed without leaving behind any dangling references that could cause compilation errors or runtime issues.Given this information, it appears that the removal of these functions has been handled correctly in the context of the codebase.
* 21-26: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [13-17]Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to the removed functions. rg --type go 'optionsDA2PB|optionsPB2DA'Length of output: 42
The
blobsPB2DA
function appears to be unchanged and should correctly handlenil
inputs by returning an empty slice. This is consistent with the PR's objectives.proxy/server.go (1)
- 60-60: The update to the
Submit
function in theproxySrv
struct to userequest.GasPrice
directly is in line with the PR's objectives to simplify gas pricing.proxy/client.go (1)
- 92-95: The changes to the
Submit
function in theClient
type to accept agasPrice
parameter and the inclusion of theGasPrice
field in theSubmitRequest
struct align with the PR's objectives.proto/da/da.proto (1)
- 87-87: The modification of the
SubmitRequest
message to include agas_price
field instead ofoptions
is consistent with the PR's objectives to simplify the gas pricing model.test/dummy.go (1)
- 102-102: The update to the
Submit
function in theDummyDA
type to accept agasPrice
parameter instead ofSubmitOptions
aligns with the PR's objectives.test/test_suite.go (1)
- 43-43: The updates to the test suite to pass
0
as thegasPrice
parameter inda.Submit
calls are correct and reflect the changes made in the PR.Also applies to: 48-48, 53-53, 113-113, 165-165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This PR replaces
SubmitOptions
with afloat64
GasPrice
. Fixes #30Checklist
Summary by CodeRabbit
New Features
gasPrice
parameter for submitting data.Refactor
Bug Fixes
nil
input could lead to unexpected behavior by ensuring a consistent return type.Tests