Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: rename GetIDs to GetIds #51

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions proto/da/da.proto
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ service DAService {
// Get returns Blob for each given ID, or an error.
rpc Get(GetRequest) returns (GetResponse) {}

// GetIDs returns IDs of all Blobs located in DA at given height.
rpc GetIDs(GetIDsRequest) returns (GetIDsResponse) {}
// GetIds returns IDs of all Blobs located in DA at given height.
rpc GetIds(GetIdsRequest) returns (GetIdsResponse) {}

// GetProofs returns inclusion Proofs for all Blobs located in DA at given height.
rpc GetProofs(GetProofsRequest) returns (GetProofsResponse) {}
Expand Down Expand Up @@ -70,14 +70,14 @@ message GetResponse {
repeated Blob blobs = 1;
}

// GetIDsRequest is the request type for the GetIDs rpc method.
message GetIDsRequest {
// GetIdsRequest is the request type for the GetIds rpc method.
message GetIdsRequest {
uint64 height = 1;
Namespace namespace = 2;
}

// GetIDsResponse is the response type for the GetIDs rpc method.
message GetIDsResponse {
// GetIdsResponse is the response type for the GetIds rpc method.
message GetIdsResponse {
repeated ID ids = 1;
}

Expand Down
4 changes: 2 additions & 2 deletions proxy/grpc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ func (c *Client) Get(ctx context.Context, ids []da.ID, namespace da.Namespace) (

// GetIDs returns IDs of all Blobs located in DA at given height.
func (c *Client) GetIDs(ctx context.Context, height uint64, namespace da.Namespace) ([]da.ID, error) {
req := &pbda.GetIDsRequest{Height: height, Namespace: &pbda.Namespace{Value: namespace}}
resp, err := c.client.GetIDs(ctx, req)
req := &pbda.GetIdsRequest{Height: height, Namespace: &pbda.Namespace{Value: namespace}}
resp, err := c.client.GetIds(ctx, req)
if err != nil {
return nil, err
}
Expand Down
4 changes: 2 additions & 2 deletions proxy/grpc/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ func (p *proxySrv) Get(ctx context.Context, request *pbda.GetRequest) (*pbda.Get
return &pbda.GetResponse{Blobs: blobsDA2PB(blobs)}, err
}

func (p *proxySrv) GetIDs(ctx context.Context, request *pbda.GetIDsRequest) (*pbda.GetIDsResponse, error) {
func (p *proxySrv) GetIds(ctx context.Context, request *pbda.GetIdsRequest) (*pbda.GetIdsResponse, error) {
ids, err := p.target.GetIDs(ctx, request.Height, request.Namespace.GetValue())
if err != nil {
return nil, err
}

return &pbda.GetIDsResponse{Ids: idsDA2PB(ids)}, nil
return &pbda.GetIdsResponse{Ids: idsDA2PB(ids)}, nil
}

func (p *proxySrv) Commit(ctx context.Context, request *pbda.CommitRequest) (*pbda.CommitResponse, error) {
Expand Down
Loading
Loading