Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump celestia-node to rc12 and celestia-app to rc14 #62

Merged
merged 1 commit into from
Sep 12, 2023
Merged

deps: Bump celestia-node to rc12 and celestia-app to rc14 #62

merged 1 commit into from
Sep 12, 2023

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Sep 12, 2023 •
edited
Loading

Overview

Bump celestia-node to v0.11.0-rc12 and celestia-app to v1.0.0-rc-14

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal changed the title Update celestia-node to rc12 and celestia-app to rc14 deps: Update celestia-node to rc12 and celestia-app to rc14 Sep 12, 2023
@Manav-Aggarwal Manav-Aggarwal changed the title deps: Update celestia-node to rc12 and celestia-app to rc14 deps: Bump celestia-node to rc12 and celestia-app to rc14 Sep 12, 2023
@Manav-Aggarwal Manav-Aggarwal added the dependencies Pull requests that update a dependency file label Sep 12, 2023
@Manav-Aggarwal Manav-Aggarwal self-assigned this Sep 12, 2023
@gupadhyaya
Copy link
Member

@Manav-Aggarwal can you use https://github.com/celestiaorg/celestia-node/releases/tag/v0.11.0-rc13

@Manav-Aggarwal
Copy link
Member Author

@Manav-Aggarwal can you use https://github.com/celestiaorg/celestia-node/releases/tag/v0.11.0-rc13

That results in the following output when running it:

The folder /home/celestia/.celestia-app does not exist.
/opt/entrypoint.sh: line 22: /bin/celestia-appd: cannot execute: required file not found
/opt/entrypoint.sh: line 23: /bin/celestia-appd: cannot execute: required file not found
/opt/entrypoint.sh: line 25: /bin/celestia-appd: cannot execute: required file not found
/opt/entrypoint.sh: line 25: /bin/celestia-appd: cannot execute: required file not found
/opt/entrypoint.sh: line 26: /bin/celestia-appd: cannot execute: required file not found
/opt/entrypoint.sh: line 30: /bin/celestia-appd: cannot execute: required file not found
sed: /home/celestia/.celestia-app/config/config.toml: No such file or directory
sed: /home/celestia/.celestia-app/config/config.toml: No such file or directory
sed: /home/celestia/.celestia-app/config/config.toml: No such file or directory
sed: /home/celestia/.celestia-app/config/config.toml: No such file or directory
sed: /home/celestia/.celestia-app/config/config.toml: No such file or directory
cp: can't stat '/home/celestia/.celestia-app/keyring-test/': No such file or directory
/opt/entrypoint.sh: line 60: /bin/celestia-appd: cannot execute: required file not found

@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review September 12, 2023 15:01
jcstein
jcstein approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested here

MSevey
MSevey approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@nashqueue nashqueue merged commit 4ecd750 into main Sep 12, 2023
7 checks passed
@nashqueue nashqueue deleted the manav/update_to_rc12 branch September 12, 2023 15:27
@jcstein
Copy link
Member

jcstein commented Sep 12, 2023

my test run did have The folder /home/celestia/.celestia-app does not exist. but not the rest of errors in @Manav-Aggarwal's output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey approved these changes

@jcstein jcstein jcstein approved these changes

@nashqueue nashqueue nashqueue approved these changes

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

Assignees

@Manav-Aggarwal Manav-Aggarwal

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manav-Aggarwal @gupadhyaya @jcstein @MSevey @nashqueue