Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: bump celestia-da #82

Merged
merged 3 commits into from
Jan 4, 2024
Merged

docker: bump celestia-da #82

merged 3 commits into from
Jan 4, 2024

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Dec 18, 2023

Overview

This PR updates celestia-da to v0.12.1 which includes SubmitOptions.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Refactor
    • Updated the Docker base image for improved performance and stability.

Copy link

coderabbitai bot commented Dec 18, 2023

Walkthrough

The Dockerfile has been updated to change the base image from "ghcr.io/rollkit/celestia-da:v0.12.1-rc3" to "ghcr.io/rollkit/celestia-da:49633a0". This suggests a shift in the base image used for the container, possibly to a more recent or customized version.

Changes

File Change Summary
Dockerfile Base image updated from "v0.12.1-rc3" to "49633a0".

🐰✨
In Docker's realm, a change so small,
A new base image, a new call.
From versioned tag to commit's charm,
CodeRabbit hops on, with no alarm. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tuxcanfly tuxcanfly marked this pull request as ready for review December 18, 2023 21:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 856ef2e and 3f3c32a.
Files selected for processing (1)
  • Dockerfile (1 hunks)
Additional comments: 1
Dockerfile (1)
  • 3-3: The base image for celestia-da has been updated to a specific commit hash. Ensure that this commit hash corresponds to the intended stable version or includes the necessary features, such as SubmitOptions.

Manav-Aggarwal
Manav-Aggarwal previously approved these changes Jan 4, 2024
@gupadhyaya gupadhyaya self-requested a review January 4, 2024 16:13
gupadhyaya
gupadhyaya previously approved these changes Jan 4, 2024
@Manav-Aggarwal Manav-Aggarwal dismissed stale reviews from gupadhyaya and themself January 4, 2024 16:16

The merge-base changed after approval.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fd55822 and eab3804.
Files selected for processing (1)
  • Dockerfile (1 hunks)
Additional comments: 2
Dockerfile (2)
  • 3-3: Ensure that the Docker image with the commit hash 49633a0 exists and includes the new SubmitOptions feature.

  • 1-5: The rest of the Dockerfile remains unchanged and appears to be correctly configured to work with the new base image.

@gupadhyaya gupadhyaya self-requested a review January 4, 2024 16:21
@Manav-Aggarwal Manav-Aggarwal merged commit 0dd21fb into main Jan 4, 2024
7 checks passed
@Manav-Aggarwal Manav-Aggarwal deleted the tux/submit-options branch January 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants