Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: expose gateway, rpc ports #86

Merged
merged 1 commit into from
Jan 9, 2024
Merged

docker: expose gateway, rpc ports #86

merged 1 commit into from
Jan 9, 2024

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Jan 5, 2024

Overview

This PR updates the entrypoint.sh script to expose gateway, rpc ports as celestia-node v0.12.2 defaults to the loopback interface by default.

While here, bump celestia-da to v0.12.1-rc3

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Updated the application base image to a newer version for enhanced stability and performance.
    • Improved network configuration with new gateway and RPC address settings for better connectivity and access control.

Copy link

coderabbitai bot commented Jan 5, 2024

Walkthrough

The recent update involves upgrading the base image in the Dockerfile to a newer release candidate version, and enhancing the network configuration in the entrypoint.sh script by adding flags that define the gateway and RPC addresses to listen on all interfaces.

Changes

File(s) Change Summary
Dockerfile Base image updated from 49633a0 to v0.12.1-rc3.
entrypoint.sh Added --gateway.addr 0.0.0.0 and --rpc.addr 0.0.0.0 flags.

🐇✨
In the Docker's den, beneath the code's vast sky,
A rabbit hops along, versions waving goodbye.
With flags unfurled on network's open sea,
It bounds ahead, through ports of possibility. 🚀🌐

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0dd21fb and d270898.
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • Dockerfile
Additional comments: 2
entrypoint.sh (2)
  • 86-87: The addition of --gateway.addr 0.0.0.0 and --rpc.addr 0.0.0.0 flags correctly opens the gateway and RPC services to all network interfaces, aligning with the PR objectives. Ensure that the security implications of this change are considered and documented, as exposing these services can increase the attack surface.

  • 83-89: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [76-76]

The use of openssl rand to generate a unique CELESTIA_NAMESPACE is a good practice for ensuring uniqueness in a distributed environment.

entrypoint.sh Show resolved Hide resolved
@tuxcanfly tuxcanfly merged commit c696751 into main Jan 9, 2024
7 checks passed
@tuxcanfly tuxcanfly deleted the tux/fix-gateway branch January 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants