-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: expose gateway, rpc ports #86
Conversation
WalkthroughThe recent update involves upgrading the base image in the Dockerfile to a newer release candidate version, and enhancing the network configuration in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (2)
- Dockerfile (1 hunks)
- entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- Dockerfile
Additional comments: 2
entrypoint.sh (2)
86-87: The addition of
--gateway.addr 0.0.0.0
and--rpc.addr 0.0.0.0
flags correctly opens the gateway and RPC services to all network interfaces, aligning with the PR objectives. Ensure that the security implications of this change are considered and documented, as exposing these services can increase the attack surface.83-89: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [76-76]
The use of
openssl rand
to generate a uniqueCELESTIA_NAMESPACE
is a good practice for ensuring uniqueness in a distributed environment.
Overview
This PR updates the
entrypoint.sh
script to expose gateway, rpc ports as celestia-nodev0.12.2
defaults to the loopback interface by default.While here, bump celestia-da to
v0.12.1-rc3
Checklist
Summary by CodeRabbit