Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: bump celestia-da to v0.12.6 #87

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Jan 12, 2024

Overview

This PR updates celestia-da to v0.12.6

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated the application to use a newer base image for enhanced stability and performance.
  • Improvements

    • Increased timeout settings for commit and propose actions to improve reliability during network operations.

Copy link

coderabbitai bot commented Jan 12, 2024

Walkthrough

The project's Docker environment has been updated with a newer base image for celestia-da, enhancing stability or features with the jump from v0.12.1-rc3 to v0.12.6. Additionally, the consensus timings within entrypoint.sh have been relaxed, doubling the timeout_commit and timeout_propose durations from 1 second to 2 seconds, likely to accommodate network or processing delays and improve robustness.

Changes

File Change Summary
Dockerfile Updated celestia-da base image to v0.12.6
entrypoint.sh Increased timeout_commit and timeout_propose from "1s" to "2s"

Poem

In the code warren, changes abound,
From v0.12.1 to .6 we've found.
🕒 Timeouts grow from one to two,
🎉 A rabbit's cheer for the patient crew!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c696751 and e43c4b1.
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • Dockerfile
Additional comments: 2
entrypoint.sh (2)
  • 36-37: The timeout settings for both commit and propose phases have been increased from 1 second to 2 seconds. This change is likely to improve the stability of the system by allowing more time for these operations. However, it's important to ensure that this change is tested thoroughly, especially in scenarios where the system is under load, to confirm that the increased timeouts do not negatively impact the overall performance or lead to unexpected behavior.

Please confirm that the updated timeout settings have been tested under various conditions to ensure they behave as expected.

  • 36-37: The usage of sed -i'.bak' is a good practice for compatibility across different systems, as it works with both GNU and BSD versions of sed. This ensures that the script will be portable and can run on different Unix-like operating systems without modification.

entrypoint.sh Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
Manav-Aggarwal
Manav-Aggarwal previously approved these changes Jan 12, 2024
@tuxcanfly tuxcanfly changed the title docker: bump celestia-da to v0.12.5 docker: bump celestia-da to v0.12.6 Jan 12, 2024
@tuxcanfly tuxcanfly force-pushed the tux/bump-celestia-da branch from e43c4b1 to b635590 Compare January 12, 2024 02:17
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c696751 and b635590.
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • entrypoint.sh (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • Dockerfile
  • entrypoint.sh

@tuxcanfly tuxcanfly merged commit 8ffd019 into main Jan 12, 2024
7 checks passed
@tuxcanfly tuxcanfly deleted the tux/bump-celestia-da branch January 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants