Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): switch to latest celestia node #94

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Mar 20, 2024

Overview

This PR switches celestia-da to latest celestia node v0.13.1

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Updated the base Docker image to improve stability and performance.
  • Chores
    • Adjusted Dockerfile settings, including exposed ports for enhanced security.
    • Modified startup script for streamlined operation and configuration.

Copy link

coderabbitai bot commented Mar 20, 2024

Walkthrough

The update involves transitioning the base image in the Dockerfile from an older version (v0.12.9) of the Celestia DA to a newer version (v0.13.1) of the Celestia Node. It also includes adjustments to the exposed ports by removing port 26650. Additionally, the entrypoint.sh script sees changes in the command used for initiating and launching the bridge, moving from celestia-da to simply celestia, and drops the configuration related to CELESTIA_NAMESPACE.

Changes

File Change Summary
Dockerfile Updated base image to ghcr.io/celestiaorg/celestia-node:v0.13.1, removed port 26650 exposure
entrypoint.sh Changed command from celestia-da to celestia, removed CELESTIA_NAMESPACE configuration

🐇✨
In the world of code, where changes bound,
A leap from old to new, a path we've found.
Ports and scripts, in harmony they shift,
A node evolves, through clouds it drifts.
So here's to progress, in bytes and bits,
For every hop, a future it knits.
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tuxcanfly tuxcanfly requested a review from gupadhyaya March 20, 2024 15:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6220c10 and 2ce1da1.
Files selected for processing (2)
  • Dockerfile (2 hunks)
  • entrypoint.sh (1 hunks)
Additional comments: 3
Dockerfile (2)
  • 3-3: The update to the base image ghcr.io/celestiaorg/celestia-node:v0.13.1 aligns with the PR objectives to use the latest Celestia node version. Ensure that this version is compatible with the rest of the project's dependencies and has been tested for any potential security vulnerabilities.
  • 21-21: The modification of exposed ports to exclude port 26650 and include ports 26657, 26658, 26659, and 9090 should be verified to ensure it aligns with the networking requirements and security best practices of the new Celestia node version. Confirm that these changes do not inadvertently expose the project to security vulnerabilities or disrupt existing network configurations.
entrypoint.sh (1)
  • 76-77: The change in command invocation from celestia-da to celestia for initializing and starting the bridge is in line with the PR objectives to adapt to the new Celestia node version. Ensure that this change has been tested thoroughly to confirm that the bridge initializes and starts as expected without any issues.

entrypoint.sh Show resolved Hide resolved
@gupadhyaya gupadhyaya enabled auto-merge March 20, 2024 15:15
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gupadhyaya gupadhyaya merged commit a7aa7c3 into main Mar 20, 2024
7 checks passed
@gupadhyaya gupadhyaya deleted the tux/celestia-node-v0.13.1 branch March 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants