Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add ABCI method needed for Fraud Proof Verification #67

Merged
merged 10 commits into from
Oct 13, 2022

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Aug 26, 2022

Adds the following method required for Fraud Proof Verification to the ABCI interface:

VerifyFraudProof (FraudProof, expectedAppHash) → VerifiedSuccess

Closes: #68

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (manav/abci_modify_generate@effa465). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             manav/abci_modify_generate      #67   +/-   ##
=============================================================
  Coverage                              ?   45.51%           
=============================================================
  Files                                 ?      279           
  Lines                                 ?    51653           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    23510           
  Misses                                ?    26282           
  Partials                              ?     1861           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Manav-Aggarwal Manav-Aggarwal changed the title Add verifyFraudProof ABCI method for verification Add verifyFraudProof ABCI method for Verification Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal changed the title Add verifyFraudProof ABCI method for Verification Add ACBI method needed for Fraud Proof Verification Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal linked an issue Aug 27, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal self-assigned this Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review August 27, 2022 00:14
@Manav-Aggarwal Manav-Aggarwal changed the title Add ACBI method needed for Fraud Proof Verification Add ABCI method needed for Fraud Proof Verification Aug 27, 2022
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see a unit test to cover the newly implemented methods. Even basic "smoke test" just showing that nothing is panic-ing when methods are executed against the mock.

Also please address linter issues.

@Manav-Aggarwal Manav-Aggarwal changed the base branch from manav/abci_modify_generate to abci_fraud_proofs October 11, 2022 18:10
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal tzdybal merged commit 8be9b54 into abci_fraud_proofs Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ABCI method needed for Fraud Proof Verification
4 participants