This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
forked from tendermint/tendermint
-
Notifications
You must be signed in to change notification settings - Fork 3
Add ABCI method needed for Fraud Proof Verification #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## manav/abci_modify_generate #67 +/- ##
=============================================================
Coverage ? 45.51%
=============================================================
Files ? 279
Lines ? 51653
Branches ? 0
=============================================================
Hits ? 23510
Misses ? 26282
Partials ? 1861 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Manav-Aggarwal
changed the title
Add verifyFraudProof ABCI method for verification
Add verifyFraudProof ABCI method for Verification
Aug 27, 2022
Manav-Aggarwal
changed the title
Add verifyFraudProof ABCI method for Verification
Add ACBI method needed for Fraud Proof Verification
Aug 27, 2022
Manav-Aggarwal
changed the title
Add ACBI method needed for Fraud Proof Verification
Add ABCI method needed for Fraud Proof Verification
Aug 27, 2022
tzdybal
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to see a unit test to cover the newly implemented methods. Even basic "smoke test" just showing that nothing is panic-ing when methods are executed against the mock.
Also please address linter issues.
tzdybal
force-pushed
the
manav/abci_modify_generate
branch
from
October 11, 2022 11:51
effa465
to
a0b60a4
Compare
Manav-Aggarwal
changed the base branch from
manav/abci_modify_generate
to
abci_fraud_proofs
October 11, 2022 18:10
tzdybal
force-pushed
the
manav/abci_add_verify
branch
from
October 13, 2022 07:47
5006935
to
f80486a
Compare
tzdybal
force-pushed
the
manav/abci_add_verify
branch
from
October 13, 2022 07:53
f80486a
to
408debe
Compare
tzdybal
reviewed
Oct 13, 2022
…to take partial block
tzdybal
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following method required for Fraud Proof Verification to the ABCI interface:
VerifyFraudProof (FraudProof, expectedAppHash) → VerifiedSuccess
Closes: #68