Add unit tests distinguishing modulePaths from moduleDirectories

rollup · Feb 10, 2022 · 9d6a580 · 9d6a580
1 parent 82069ce
commit 9d6a580
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 0 deletions.
diff --git a/packages/node-resolve/test/fixtures/custom-module-path/main.js b/packages/node-resolve/test/fixtures/custom-module-path/main.js
@@ -0,0 +1,3 @@
+import PACKAGE, {dependency} from 'package-with-dependency';
+
+export { PACKAGE, dependency };
diff --git a/...ode-resolve/test/fixtures/custom-module-path/node_modules/package-with-dependency/main.js b/...ode-resolve/test/fixtures/custom-module-path/node_modules/package-with-dependency/main.js
diff --git a/...s/custom-module-path/node_modules/package-with-dependency/node_modules/dependency/main.js b/...s/custom-module-path/node_modules/package-with-dependency/node_modules/dependency/main.js
diff --git a/...tom-module-path/node_modules/package-with-dependency/node_modules/dependency/package.json b/...tom-module-path/node_modules/package-with-dependency/node_modules/dependency/package.json
diff --git a/...esolve/test/fixtures/custom-module-path/node_modules/package-with-dependency/package.json b/...esolve/test/fixtures/custom-module-path/node_modules/package-with-dependency/package.json
diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
@@ -257,6 +257,36 @@ test('allows custom moduleDirectories with legacy customResolveOptions.moduleDir
   t.snapshot(warnings);
 });
 
+test('custom moduleDirectories do not support nested dependencies', async (t) => {
+  const warnings = [];
+  const bundle = await rollup({
+    input: 'custom-module-path/main.js',
+    onwarn: (warning) => warnings.push(warning),
+    plugins: [
+      nodeResolve({
+        moduleDirectories: [join(process.cwd(), 'custom-module-path/node_modules')]
+      })
+    ]
+  });
+
+  t.is(warnings.length, 1);
+  t.is(bundle.cache.modules.length, 2);
+});
+
+test('allows custom modulePaths', async (t) => {
+  const bundle = await rollup({
+    input: 'custom-module-path/main.js',
+    onwarn: failOnWarn(t),
+    plugins: [
+      nodeResolve({
+        modulePaths: [join(process.cwd(), 'custom-module-path/node_modules')]
+      })
+    ]
+  });
+
+  t.is(bundle.cache.modules.length, 3);
+});
+
 test('ignores deep-import non-modules', async (t) => {
   const warnings = [];
   const bundle = await rollup({
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import PACKAGE, {dependency} from 'package-with-dependency';

		export { PACKAGE, dependency };