Skip to content

Commit

Permalink
fix(babel): consider path delimeter on windows (#1090)
Browse files Browse the repository at this point in the history
* fix(babel): consider path delimeter on windows (#1089)

* Fixed lint issues

* Added reference to issue in babel

* chore: update comment linking to the resolved Babel issue

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
  • Loading branch information
atti187 and Andarist authored Feb 22, 2022
1 parent 8835dd2 commit c259de5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/babel/src/preflightCheck.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ function helpersTestTransform() {
const mismatchError = (actual, expected, filename) =>
`You have declared using "${expected}" babelHelpers, but transforming ${filename} resulted in "${actual}". Please check your configuration.`;

const inheritsHelperRe = /\/helpers\/(esm\/)?inherits/;
// Revert to /\/helpers\/(esm\/)?inherits/ when Babel 8 gets released, this was fixed in https://github.com/babel/babel/issues/14185
const inheritsHelperRe = /[\\/]+helpers[\\/]+(esm[\\/]+)?inherits/;

export default async function preflightCheck(ctx, babelHelpers, transformOptions) {
const finalOptions = addBabelPlugin(transformOptions, helpersTestTransform);
Expand Down

0 comments on commit c259de5

Please sign in to comment.