Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inject): rollup is optional peer dependency #1272

Closed
wants to merge 1 commit into from

Conversation

milahu
Copy link

@milahu milahu commented Sep 24, 2022

Rollup Plugin Name: inject

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Relevant issues:

Description

this plugin can be used from vite
for example in https://github.com/sodatea/vite-plugin-node-stdlib-browser

in this case, rollup is not installed

this fix should also be applied to other rollup plugins

workaround for pnpm: add this to package.json

{
  "pnpm": {
    "peerDependencyRules": {
      "ignoreMissing": [
        "rollup"
      ]
    }
  }
}

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Considering your arguments, I added this change to all PRs I just created for Rollup 3 compatibility of plugins, see e.g. #1292. This supersedes your PR, but we can still merge it first if you want the contribution.

@milahu
Copy link
Author

milahu commented Oct 1, 2022

thanks : )

This supersedes your PR, but we can still merge it first if you want the contribution.

i dont care

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants