Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(json): correct minimatch to picomatch #1332

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

sapphi-red
Copy link
Contributor

Rollup Plugin Name: json

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

plugin-json now uses pluginutils@^5.0.1 that uses picomatch instead of minimatch (previously: ^3.0.8).
I updated document from "minimatch pattern" to "picomatch pattern". Since they have a slightly different behavior.

Related: #1260

@shellscape
Copy link
Collaborator

thanks!

@shellscape shellscape merged commit 5250b88 into rollup:master Nov 27, 2022
@sapphi-red sapphi-red deleted the chore-json-minimatch-docs branch November 29, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants