fix(typescript): fix sourcemap sourcecontent referencing non-existent files

[ianyong]

Rollup Plugin Name: @rollup/plugin-typescript

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

• Fixes [@rollup/plugin-typescript] Source map's sourceMappingURL references a non-existent file #1570

Description

In #1555, I changed:

plugins/packages/typescript/src/outputFile.ts

Lines 23 to 28 in 303ff16

	/**
	* Checks if the given OutputFile represents some source map
	*/
	function isMapOutputFile(name: string): boolean {
	return name.endsWith('.map');
	}

to:

plugins/packages/typescript/src/outputFile.ts

Lines 23 to 28 in 0278630

	/**
	* Checks if the given OutputFile represents some source map
	*/
	export function isMapOutputFile(name: string): boolean {
	return name.endsWith('ts.map');
	}

It turns out that this was a mistake (oops!) because isMapOutputFile is also used in the load build hook to determine the map file for every code file. With the change made above, .js.map files were incorrectly being treated as declaration files instead of map files.

To resolve this issue, I have split the predicate functions:

/**
 * Checks if the given OutputFile represents some source map
 */
export function isMapOutputFile(name: string): boolean {
  return name.endsWith('.map');
}

/**
 * Checks if the given OutputFile represents some TypeScript source map
 */
export function isTypeScriptMapOutputFile(name: string): boolean {
  return name.endsWith('ts.map');
}

isMapOutputFile is used to determine if a file is a map file for use in the load build hook while isTypeScriptMapOutputFile is used to determine if a file is a TypeScript map file for emitting.

[ianyong]

It seems that pnpm 8 has dropped support for Node.js 14. The CI pipeline will need to be updated after 0278630.

[shellscape]

@ianyong please update your branch from upstream so we can run the latest CI