This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

Fix [dirname] substitution on Windows #21

Merged

Ashot-KR merged 1 commit into rollup:master from ryan-codingintrigue:master

Apr 10, 2019

Contributor

ryan-codingintrigue commented Apr 10, 2019

This should be the output path, which is a relative Javascript path, not a filesystem path.

As it stands with using path.sep windows clients will get output like this:

var fileName = "path/to/the\file.png";

This fixes the issue for all clients by hardcoding the / character for the dirname substitution


          Fix path.sep on Windows - this is a Javascript path, not a filesystem…

cc8cccf

… one

Ashot-KR merged commit e194eac into rollup:master

Ashot-KR commented Apr 10, 2019

Ooops…
Thanks!
Version 2.2.1 published on npm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet