feat: support using for RollupBuild
#5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5721 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 258 258
Lines 8069 8070 +1
Branches 1360 1360
=======================================
+ Hits 7989 7990 +1
Misses 53 53
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks, this looks good. I still think, though, that it would be nice to have at least a hint in the docs that you can do that. How about in the example, we replace the // create a bundle comment with something like
// Create a bundle. If you are using TypeScript or a runtime that
// supports it, you can write
//
// await using bundle = await rollup(inputOptions);
//
// instead and do not need to close the bundle explicitly below.
shulaoda
force-pushed
the
feat/support-using-for-rollup-build
branch
from
1fd869a to
d163eb3
Compare
lukastaegert
approved these changes
Nov 13, 2024
|
This PR has been released as part of rollup@4.26.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5714
Description
Since this is a new
TypeScriptfeature, I'm not sure how to add additional test cases on theJavaScriptside.