Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting index predicate for upserts w/ partial unique indices #395

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

smaximov
Copy link
Contributor

@smaximov smaximov commented Feb 19, 2021

This PR adds support for inferring partial unique indices in Postgres upserts by allowing the user to set index predicates (as in ON CONFLICT (...) WHERE <INDEX_PREDICATE>) on Upsert commands.

Resolves #394

@smaximov smaximov requested a review from solnic as a code owner February 19, 2021 12:16
@solnic solnic added this to the 3.4.0 milestone Feb 22, 2021
Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@solnic
Copy link
Member

solnic commented Mar 6, 2021

@flash-gordon 👋🏻 are you OK with this?

Copy link
Member

@flash-gordon flash-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flash-gordon flash-gordon merged commit 7766d14 into rom-rb:master Mar 23, 2021
@solnic solnic modified the milestones: 3.4.0, 3.5.0 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Upsert command does not support specifying index predicate for partial unique indices
3 participants