Show done actions in project view & two UI tweaks #51
Conversation
|
Actually don't merge this, I just noticed it causes extra "Completed Actions" sections to appear in other dashboards. Update: fixed and re-pushed. |
simonbaird
force-pushed
the
done-action-tweaks
branch
2 times, most recently
from
20b03f4 to
9ba5ac2
Compare
|
Still needs some work to fix sorting. Let me know if you think the sorting of completed items by completed date should be enabled with a setting. |
simonbaird
force-pushed
the
done-action-tweaks
branch
from
9ba5ac2 to
bcbed19
Compare
|
Commit bcbed19 is working at least. Might clean things up a bit further. Pull request was a bit premature perhaps, apologies. |
|
@simonbaird Thanks for you work Simon. I will take a look at this tonight. I think your sort by |
It's nice to see what's been done already when looking at a project. See Issue roma0104#50.
Add the logic to list-view-suffix next to the delete button so it's consistent everywhere. Also add a general purpose class to the stylesheet for lighter text.
I think it looks better if these are less prominent cosmetically. Extend the gsd-muted class added in the previous commit to apply an opacity to the images. Also considered adding a wrapper element around everything in list-view-suffix, but decided against it for now.
Found it missing in a couple of places.
It's nice if recently completed items are show iirst rather than the default title sort.
simonbaird
force-pushed
the
done-action-tweaks
branch
from
bcbed19 to
fe8a25f
Compare
|
A quick demo here: Don't merge this in any case. I'll put "Fix missing colon typo" in a new PR. |
|
Should probably be cut up into separate pull requests. |
|
Apologies, that wasn't very tidy. |
|
But thanks for the merge. :) |
|
Thank you for your contributions. I wasn't sure if you were working on something related to this pull so I left it open. But everything committed looked stand-alone. Given my skill with git and coding, it is surprising this thing actually works and some else project hasn't shown up in the repo too. |
No description provided.