Skip to content

Commit

Permalink
react-dev-utils/openBrowser now supports urls with 2+ params (faceboo…
Browse files Browse the repository at this point in the history
…k#2076)

* react-dev-utils/openBrowser now supports urls with 2+ params

Fixed facebook#2047

* react-dev-utils/openBrowser: encode url before open the browser
  • Loading branch information
alisonmonteiro authored and romaindso committed Jul 10, 2017
1 parent e8ecf48 commit 5c979ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-dev-utils/openBrowser.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function startBrowserProcess(browser, url) {
// Try our best to reuse existing tab
// on OS X Google Chrome with AppleScript
execSync('ps cax | grep "Google Chrome"');
execSync('osascript openChrome.applescript ' + url, {
execSync('osascript openChrome.applescript "' + encodeURI(url) + '"', {
cwd: __dirname,
stdio: 'ignore',
});
Expand Down

0 comments on commit 5c979ee

Please sign in to comment.