Don't expose file last modifed date/time via cachebusted URLs

Closes dnnsoftware#2850
roman-yagodin · Jan 29, 2020 · 6b54471 · 6b54471
1 parent d668508
commit 6b54471
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/DNN Platform/Library/Entities/Portals/PortalSettings.cs b/DNN Platform/Library/Entities/Portals/PortalSettings.cs
@@ -634,12 +634,9 @@ public string AddCompatibleHttpHeader
             }
         }
 
-        /*
-         * add a cachebuster parameter to generated file URI's
-         * 
-         * of the form ver=[file timestame] ie ver=2015-02-17-162255-735
-         * 
-         */
+        /// <summary>
+        /// If true then add a cachebuster parameter to generated file URI's.
+        /// </summary>
         public bool AddCachebusterToResourceUris
         {
             get

diff --git a/DNN Platform/Library/Services/FileSystem/Providers/StandardFolderProvider.cs b/DNN Platform/Library/Services/FileSystem/Providers/StandardFolderProvider.cs
@@ -216,7 +216,9 @@ public override string GetFileUrl(IFileInfo file)
             // Does site management want the cachebuster parameter?
             if (portalSettings.AddCachebusterToResourceUris)
             {
-                return TestableGlobals.Instance.ResolveUrl(fullPath + "?ver=" + file.LastModificationTime.ToString("yyyy-MM-dd-HHmmss-fff"));
+                var cachebusterToken = UrlUtils.EncryptParameter(file.LastModificationTime.GetHashCode().ToString());
+
+                return TestableGlobals.Instance.ResolveUrl(fullPath + "?ver=" + cachebusterToken);
             }
 
             return TestableGlobals.Instance.ResolveUrl(fullPath);