Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail mempool sync on missing transactions #997

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

romanz
Copy link
Owner

@romanz romanz commented Jan 27, 2024

Otherwise, RBF may cause current sync implementation to fail.

@romanz
Copy link
Owner Author

romanz commented Jan 27, 2024

It can also handle following transient RPC errors:

mempool sync failed: batch getrawtransaction request failed: transport error: Couldn't connect to host: Resource temporarily unavailable (os error 11)

@antonilol
Copy link
Contributor

antonilol commented Jan 28, 2024

when running this pr on my node i got the following two messages (alongside the usual indexing 1 blocks, chain updated):
missing mempool entry: 9c75d38a3eeca395a2c6bb6bb4b14bf8126334f16c2da57b7a1753b930890748
and
missing mempool tx: f10483eaf7defa69ea77932b0839379466bfa5bec9a8fa9255e7aa0b1dd7ef45
(checked both on mempool.space and they both have been replaced)
is this a problem or just indicates that after replacement it cant be found anymore?

@antonilol
Copy link
Contributor

missing mempool tx/entry is common in the log, for replaced transactions.
i did however find a whole list of missing mempool entry warnings followed by mempool sync failed: batch getmempoolentry request failed: transport error: Couldn't connect to host: Resource temporarily unavailable (os error 11), the transaction ids logged were all confirmed transactions from the same block

@romanz
Copy link
Owner Author

romanz commented Feb 23, 2024

is this a problem or just indicates that after replacement it cant be found anymore?

It is not a problem - probably just a regular RBF :)

@romanz
Copy link
Owner Author

romanz commented Feb 23, 2024

Resource temporarily unavailable (os error 11)

Has this error also happened before this PR?

Otherwise, RBF may cause current sync implementation to fail.
@antonilol
Copy link
Contributor

Resource temporarily unavailable (os error 11)

Has this error also happened before this PR?

not that i know of, at least not from 19 (log start) to 28 (first occurrence of that os error) january

@romanz
Copy link
Owner Author

romanz commented Mar 2, 2024

OK, thanks @antonilol!
I'll merge this PR, and let's continue running it to see how it goes :)

@romanz romanz merged commit 576b5b2 into master Mar 2, 2024
8 checks passed
@romanz romanz deleted the batch-refactor branch March 2, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants