Merge remote-tracking branch 'origin/main' into feature/promote-rules-v2

rome · Oct 28, 2022 · 0139d44 · 0139d44
2 parents 74c69b9 + a9db0f0
commit 0139d44
Show file tree

Hide file tree

Showing 6 changed files with 56 additions and 8 deletions.
diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs
diff --git a/...ntic_analyzers/nursery/no_explicit_any.rs → .../src/analyzers/nursery/no_explicit_any.rs b/...ntic_analyzers/nursery/no_explicit_any.rs → .../src/analyzers/nursery/no_explicit_any.rs
diff --git a/crates/rome_js_analyze/src/analyzers/style/no_negation_else.rs b/crates/rome_js_analyze/src/analyzers/style/no_negation_else.rs
@@ -139,8 +139,8 @@ fn is_negation(node: &JsAnyExpression) -> Option<bool> {
             match (expr.operator().ok(), expr.argument().ok()) {
                 (
                     Some(JsUnaryOperator::LogicalNot),
-                    Some(JsAnyExpression::JsUnaryExpression(_)),
-                ) => Some(false),
+                    Some(JsAnyExpression::JsUnaryExpression(inner_unary)),
+                ) => Some(inner_unary.operator().ok()? != JsUnaryOperator::LogicalNot),
                 _ => Some(true),
             }
         }

diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/tests/specs/style/noNegationElse/issue_3141.js b/crates/rome_js_analyze/tests/specs/style/noNegationElse/issue_3141.js
@@ -1,4 +1,6 @@
-// valid
+// invalid
 function f() {
     return !!specs.variables ? specs.variables(props) : {};
-}
+}
+// valid
+!-a ? b : c
diff --git a/crates/rome_js_analyze/tests/specs/style/noNegationElse/issue_3141.js.snap b/crates/rome_js_analyze/tests/specs/style/noNegationElse/issue_3141.js.snap
@@ -4,10 +4,33 @@ expression: issue_3141.js
 ---
 # Input
 ```js
-// valid
+// invalid
 function f() {
     return !!specs.variables ? specs.variables(props) : {};
 }
+// valid
+!-a ? b : c
+```
+
+# Diagnostics
+```
+issue_3141.js:6:1 lint/style/noNegationElse  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Invert blocks when performing a negation test.
+  
+    4 │ }
+    5 │ // valid
+  > 6 │ !-a ? b : c
+      │ ^^^^^^^^^^^
+  
+  i Suggested fix: Exchange alternate and consequent of the node
+  
+    4 4 │   }
+    5 5 │   // valid
+    6   │ - !-a·?·b·:·c
+      6 │ + -a·?·c·:·b
+  
+
 ```