feat(rome_js_analyze): promote rules

rome · Oct 25, 2022 · 12a515a · 12a515a
1 parent 42d9f1d
commit 12a515a
Show file tree

Hide file tree

Showing 150 changed files with 1,299 additions and 1,133 deletions.
diff --git a/crates/rome_diagnostics_categories/src/categories.rs b/crates/rome_diagnostics_categories/src/categories.rs
@@ -9,6 +9,7 @@
 
 define_dategories! {
     // Lint categories
+    // correctness
     "lint/correctness/noArguments": "https://rome.tools/docs/lint/rules/noArguments",
     "lint/correctness/noAsyncPromiseExecutor": "https://rome.tools/docs/lint/rules/noAsyncPromiseExecutor",
     "lint/correctness/noCatchAssign": "https://rome.tools/docs/lint/rules/noCatchAssign",
@@ -31,44 +32,49 @@ define_dategories! {
     "lint/correctness/noUnsafeNegation": "https://rome.tools/docs/lint/rules/noUnsafeNegation",
     "lint/correctness/noUnusedTemplateLiteral": "https://rome.tools/docs/lint/rules/noUnusedTemplateLiteral",
     "lint/correctness/useBlockStatements": "https://rome.tools/docs/lint/rules/useBlockStatements",
-    "lint/correctness/useSimplifiedLogicExpression": "https://rome.tools/docs/lint/rules/useSimplifiedLogicExpression",
     "lint/correctness/useSingleCaseStatement": "https://rome.tools/docs/lint/rules/useSingleCaseStatement",
     "lint/correctness/useSingleVarDeclarator": "https://rome.tools/docs/lint/rules/useSingleVarDeclarator",
-    "lint/correctness/useTemplate": "https://rome.tools/docs/lint/rules/useTemplate",
     "lint/correctness/useValidTypeof": "https://rome.tools/docs/lint/rules/useValidTypeof",
     "lint/correctness/useWhile": "https://rome.tools/docs/lint/rules/useWhile",
-    "lint/nursery/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
-    "lint/nursery/noNewSymbol": "https://rome.tools/docs/lint/rules/noNewSymbol",
-    "lint/nursery/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
-    "lint/nursery/noUnreachable": "https://rome.tools/docs/lint/rules/noUnreachable",
-    "lint/nursery/noUnusedVariables": "https://rome.tools/docs/lint/rules/noUnusedVariables",
-    "lint/nursery/noUselessFragments": "https://rome.tools/docs/lint/rules/noUselessFragments",
-    "lint/nursery/useButtonType": "https://rome.tools/docs/lint/rules/useButtonType",
-    "lint/nursery/useCamelCase": "https://rome.tools/docs/lint/rules/useCamelCase",
-    "lint/nursery/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
-    "lint/nursery/noUndeclaredVariables": "https://rome.tools/docs/lint/rules/noUndeclaredVariables",
-    "lint/nursery/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
-    "lint/nursery/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
-    "lint/nursery/useFragmentSyntax": "https://rome.tools/docs/lint/rules/useFragmentSyntax",
-    "lint/nursery/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
-    "lint/nursery/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
-    "lint/nursery/noAutofocus": "https://rome.tools/docs/lint/rules/noAutofocus",
-    "lint/nursery/useKeyWithMouseEvents": "https://rome.tools/docs/lint/rules/useKeyWithMouseEvents",
-    "lint/nursery/useAnchorContent": "https://rome.tools/docs/lint/rules/useAnchorContent",
-    "lint/nursery/useBlankTarget": "https://rome.tools/docs/lint/rules/useBlankTarget",
-    "lint/nursery/useValidAnchor": "https://rome.tools/docs/lint/rules/useValidAnchor",
-    "lint/nursery/useKeyWithClickEvents": "https://rome.tools/docs/lint/rules/useKeyWithClickEvents",
-    "lint/nursery/noRestrictedGlobals": "https://rome.tools/docs/lint/rules/noRestrictedGlobals",
-    "lint/nursery/useFlatMap": "https://rome.tools/docs/lint/rules/useFlatMap",
-    "lint/nursery/noPositiveTabindex": "https://rome.tools/docs/lint/rules/noPositiveTabindex",
-    "lint/nursery/noConstAssign": "https://rome.tools/docs/lint/rules/noConstAssign",
-    "lint/nursery/noExplicitAny": "https://rome.tools/docs/lint/rules/noExplicitAny",
-    "lint/nursery/useValidForDirection": "https://rome.tools/docs/lint/rules/useValidForDirection",
+    "lint/correctness/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
+    "lint/correctness/noNewSymbol": "https://rome.tools/docs/lint/rules/noNewSymbol",
+    "lint/correctness/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
+    "lint/correctness/noUselessFragments": "https://rome.tools/docs/lint/rules/noUselessFragments",
+    "lint/correctness/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
+    "lint/correctness/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
+    "lint/correctness/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
+    "lint/correctness/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
+    "lint/correctness/noAutofocus": "https://rome.tools/docs/lint/rules/noAutofocus",
+    // style category
     "lint/style/noNegationElse": "https://rome.tools/docs/lint/rules/noNegationElse",
     "lint/style/noShoutyConstants": "https://rome.tools/docs/lint/rules/noShoutyConstants",
     "lint/style/useSelfClosingElements": "https://rome.tools/docs/lint/rules/useSelfClosingElements",
     "lint/style/useShorthandArrayType": "https://rome.tools/docs/lint/rules/useShorthandArrayType",
+    "lint/style/useFragmentSyntax": "https://rome.tools/docs/lint/rules/useFragmentSyntax",
+    "lint/style/useTemplate": "https://rome.tools/docs/lint/rules/useTemplate",
+    // complexity
+    "lint/complexity/useSimplifiedLogicExpression": "https://rome.tools/docs/lint/rules/useSimplifiedLogicExpression",
+
+    // a11y category
+    "lint/a11y/noPositiveTabindex": "https://rome.tools/docs/lint/rules/noPositiveTabindex",
+    "lint/a11y/useKeyWithMouseEvents": "https://rome.tools/docs/lint/rules/useKeyWithMouseEvents",
+    "lint/a11y/useAnchorContent": "https://rome.tools/docs/lint/rules/useAnchorContent",
+    "lint/a11y/useBlankTarget": "https://rome.tools/docs/lint/rules/useBlankTarget",
+    "lint/a11y/useValidAnchor": "https://rome.tools/docs/lint/rules/useValidAnchor",
+    "lint/a11y/useKeyWithClickEvents": "https://rome.tools/docs/lint/rules/useKeyWithClickEvents",
+    "lint/a11y/useButtonType": "https://rome.tools/docs/lint/rules/useButtonType",
+    // nursery
+    "lint/nursery/noRestrictedGlobals": "https://rome.tools/docs/lint/rules/noRestrictedGlobals",
+    "lint/nursery/useFlatMap": "https://rome.tools/docs/lint/rules/useFlatMap",
+    "lint/nursery/noConstAssign": "https://rome.tools/docs/lint/rules/noConstAssign",
+    "lint/nursery/noExplicitAny": "https://rome.tools/docs/lint/rules/noExplicitAny",
+    "lint/nursery/useCamelCase": "https://rome.tools/docs/lint/rules/useCamelCase",
+    "lint/nursery/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
+    "lint/nursery/noUndeclaredVariables": "https://rome.tools/docs/lint/rules/noUndeclaredVariables",
+    "lint/nursery/noUnreachable": "https://rome.tools/docs/lint/rules/noUnreachable",
+    "lint/nursery/noUnusedVariables": "https://rome.tools/docs/lint/rules/noUnusedVariables",
     ;
+
     // General categories
     "files/missingHandler",
     "format",

diff --git a/crates/rome_js_analyze/src/analyzers.rs b/crates/rome_js_analyze/src/analyzers.rs
diff --git a/crates/rome_js_analyze/src/analyzers/a11y.rs b/crates/rome_js_analyze/src/analyzers/a11y.rs
diff --git a/...c/analyzers/nursery/use_anchor_content.rs → .../src/analyzers/a11y/use_anchor_content.rs b/...c/analyzers/nursery/use_anchor_content.rs → .../src/analyzers/a11y/use_anchor_content.rs
diff --git a/...src/analyzers/nursery/use_blank_target.rs → ...ze/src/analyzers/a11y/use_blank_target.rs b/...src/analyzers/nursery/use_blank_target.rs → ...ze/src/analyzers/a11y/use_blank_target.rs
diff --git a/...zers/nursery/use_key_with_click_events.rs → ...alyzers/a11y/use_key_with_click_events.rs b/...zers/nursery/use_key_with_click_events.rs → ...alyzers/a11y/use_key_with_click_events.rs
diff --git a/...zers/nursery/use_key_with_mouse_events.rs → ...alyzers/a11y/use_key_with_mouse_events.rs b/...zers/nursery/use_key_with_mouse_events.rs → ...alyzers/a11y/use_key_with_mouse_events.rs
diff --git a/...src/analyzers/nursery/use_valid_anchor.rs → ...ze/src/analyzers/a11y/use_valid_anchor.rs b/...src/analyzers/nursery/use_valid_anchor.rs → ...ze/src/analyzers/a11y/use_valid_anchor.rs
diff --git a/crates/rome_js_analyze/src/analyzers/complexity.rs b/crates/rome_js_analyze/src/analyzers/complexity.rs
diff --git a/...ctness/use_simplified_logic_expression.rs → ...lexity/use_simplified_logic_expression.rs b/...ctness/use_simplified_logic_expression.rs → ...lexity/use_simplified_logic_expression.rs
diff --git a/crates/rome_js_analyze/src/analyzers/correctness.rs b/crates/rome_js_analyze/src/analyzers/correctness.rs
diff --git a/...ze/src/analyzers/nursery/no_auto_focus.rs → ...rc/analyzers/correctness/no_auto_focus.rs b/...ze/src/analyzers/nursery/no_auto_focus.rs → ...rc/analyzers/correctness/no_auto_focus.rs
diff --git a/...ze/src/analyzers/nursery/no_new_symbol.rs → ...rc/analyzers/correctness/no_new_symbol.rs b/...ze/src/analyzers/nursery/no_new_symbol.rs → ...rc/analyzers/correctness/no_new_symbol.rs
diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/src/analyzers/style.rs b/crates/rome_js_analyze/src/analyzers/style.rs
diff --git a/...src/analyzers/correctness/use_template.rs → ...alyze/src/analyzers/style/use_template.rs b/...src/analyzers/correctness/use_template.rs → ...alyze/src/analyzers/style/use_template.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers.rs b/crates/rome_js_analyze/src/semantic_analyzers.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/a11y.rs b/crates/rome_js_analyze/src/semantic_analyzers/a11y.rs
diff --git a/...analyzers/nursery/no_positive_tabindex.rs → ...ic_analyzers/a11y/no_positive_tabindex.rs b/...analyzers/nursery/no_positive_tabindex.rs → ...ic_analyzers/a11y/no_positive_tabindex.rs
diff --git a/...ntic_analyzers/nursery/use_button_type.rs → ...emantic_analyzers/a11y/use_button_type.rs b/...ntic_analyzers/nursery/use_button_type.rs → ...emantic_analyzers/a11y/use_button_type.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs b/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs
diff --git a/...c_analyzers/nursery/no_array_index_key.rs → ...alyzers/correctness/no_array_index_key.rs b/...c_analyzers/nursery/no_array_index_key.rs → ...alyzers/correctness/no_array_index_key.rs
diff --git a/...tic_analyzers/nursery/no_children_prop.rs → ...analyzers/correctness/no_children_prop.rs b/...tic_analyzers/nursery/no_children_prop.rs → ...analyzers/correctness/no_children_prop.rs
diff --git a/.../nursery/no_dangerously_set_inner_html.rs → ...rectness/no_dangerously_set_inner_html.rs b/.../nursery/no_dangerously_set_inner_html.rs → ...rectness/no_dangerously_set_inner_html.rs
diff --git a/...ngerously_set_inner_html_with_children.rs → ...ngerously_set_inner_html_with_children.rs b/...ngerously_set_inner_html_with_children.rs → ...ngerously_set_inner_html_with_children.rs
diff --git a/...alyzers/nursery/no_render_return_value.rs → ...ers/correctness/no_render_return_value.rs b/...alyzers/nursery/no_render_return_value.rs → ...ers/correctness/no_render_return_value.rs
diff --git a/...analyzers/nursery/no_useless_fragments.rs → ...yzers/correctness/no_useless_fragments.rs b/...analyzers/nursery/no_useless_fragments.rs → ...yzers/correctness/no_useless_fragments.rs
diff --git a/...nursery/no_void_elements_with_children.rs → ...ectness/no_void_elements_with_children.rs b/...nursery/no_void_elements_with_children.rs → ...ectness/no_void_elements_with_children.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/style.rs b/crates/rome_js_analyze/src/semantic_analyzers/style.rs
diff --git a/..._analyzers/nursery/use_fragment_syntax.rs → ...ic_analyzers/style/use_fragment_syntax.rs b/..._analyzers/nursery/use_fragment_syntax.rs → ...ic_analyzers/style/use_fragment_syntax.rs
diff --git a/...ursery/noAutofocus/noAutoFocusInvalid.jsx → ...s/a11y/noAutofocus/noAutoFocusInvalid.jsx b/...ursery/noAutofocus/noAutoFocusInvalid.jsx → ...s/a11y/noAutofocus/noAutoFocusInvalid.jsx
diff --git a/crates/rome_js_analyze/tests/specs/a11y/noAutofocus/noAutoFocusInvalid.jsx.snap b/crates/rome_js_analyze/tests/specs/a11y/noAutofocus/noAutoFocusInvalid.jsx.snap
@@ -0,0 +1,20 @@
+---
+source: crates/rome_js_analyze/tests/spec_tests.rs
+expression: noAutoFocusInvalid.jsx
+---
+# Input
+```js
+<>
+    <button autoFocus />
+    <input autoFocus />
+    <input autoFocus="true" />
+    <input autoFocus={undefined} />
+    <input autoFocus={"false"} />
+    <input autoFocus={"false"} /*comment*/ />
+    <input /*comment*/ autoFocus={"false"} />
+    <input autoFocus={"false" /*comment*/} />
+    <input /*comment*/ autoFocus={"false"} /*comment*/ />
+</>
+```
+
+
diff --git a/.../nursery/noAutofocus/noAutoFocusValid.jsx → ...ecs/a11y/noAutofocus/noAutoFocusValid.jsx b/.../nursery/noAutofocus/noAutoFocusValid.jsx → ...ecs/a11y/noAutofocus/noAutoFocusValid.jsx
diff --git a/...ery/noAutofocus/noAutoFocusValid.jsx.snap → ...11y/noAutofocus/noAutoFocusValid.jsx.snap b/...ery/noAutofocus/noAutoFocusValid.jsx.snap → ...11y/noAutofocus/noAutoFocusValid.jsx.snap
diff --git a/...nursery/noPositiveTabindex/invalidJsx.jsx → ...cs/a11y/noPositiveTabindex/invalidJsx.jsx b/...nursery/noPositiveTabindex/invalidJsx.jsx → ...cs/a11y/noPositiveTabindex/invalidJsx.jsx