chore: Upgrade to Rust 1.65.0 (#3557)

crates/rome_analyze/src/services.rs

@@ -34,6 +34,7 @@ impl MissingServicesDiagnostic {
 }
 
 pub trait FromServices: Sized {
+    #[allow(clippy::result_large_err)]
     fn from_services(
         rule_key: &RuleKey,
         services: &ServiceBag,

crates/rome_cli/tests/snap_test.rs

@@ -59,7 +59,7 @@ impl CliSnapshot {
                 let _ = write!(content, "## `{name}`\n\n");
                 let _ = write!(content, "```{extension}");
                 content.push('\n');
-                content.push_str(&**file_content);
+                content.push_str(file_content);
                 content.push('\n');
                 content.push_str("```");
                 content.push_str("\n\n")

crates/rome_fs/src/fs/memory.rs

@@ -164,15 +164,15 @@ impl<'scope> TraversalScope<'scope> for MemoryTraversalScope<'scope> {
                 let should_process_file = if base.starts_with(".") || base.starts_with("./") {
                     // we simulate absolute paths, so we can correctly strips out the base path from the path
                     let absolute_base = PathBuf::from("/").join(&base);
-                    let absolute_path = Path::new("/").join(&path);
+                    let absolute_path = Path::new("/").join(path);
                     absolute_path.strip_prefix(&absolute_base).is_ok()
                 } else {
                     path.strip_prefix(&base).is_ok()
                 };
 
                 if should_process_file {
                     let file_id = ctx.interner().intern_path(path.into());
-                    let rome_path = RomePath::new(&path, file_id);
+                    let rome_path = RomePath::new(path, file_id);
                     if !ctx.can_handle(&rome_path) {
                         continue;
                     }

crates/rome_js_analyze/src/lib.rs

@@ -38,7 +38,7 @@ pub fn metadata() -> &'static MetadataRegistry {
         };
     }
 
-    &*METADATA
+    &METADATA
 }
 
 /// Run the analyzer on the provided `root`: this process will use the given `filter`

crates/rome_js_analyze/src/semantic_analyzers/correctness/no_function_assign.rs

@@ -143,11 +143,7 @@ impl Rule for NoFunctionAssign {
             let node = reference.node();
             diag = diag.detail(node.text_trimmed_range(), "Reassigned here.");
 
-            hoisted_quantity += if reference.is_using_hoisted_declaration() {
-                1
-            } else {
-                0
-            };
+            hoisted_quantity += i32::from(reference.is_using_hoisted_declaration());
         }
 
         let diag = if hoisted_quantity > 0 {

crates/rome_js_formatter/src/builders.rs

@@ -5,9 +5,9 @@ use rome_rowan::AstNode;
 
 /// Formats a node using its [`AsFormat`] implementation but falls back to printing the node as
 /// it is in the source document if the formatting returns an [`FormatError`].
-pub const fn format_or_verbatim<'a, Node>(node: &'a Node) -> FormatNodeOrVerbatim<'a, Node>
+pub const fn format_or_verbatim<Node>(node: &Node) -> FormatNodeOrVerbatim<Node>
 where
-    Node: AstNode<Language = JsLanguage> + AsFormat<'a>,
+    Node: AstNode<Language = JsLanguage> + AsFormat,
 {
     FormatNodeOrVerbatim { node }
 }
@@ -20,7 +20,7 @@ pub struct FormatNodeOrVerbatim<'a, Node> {
 
 impl<'a, Node> Format<JsFormatContext> for FormatNodeOrVerbatim<'a, Node>
 where
-    Node: AstNode<Language = JsLanguage> + AsFormat<'a>,
+    Node: AstNode<Language = JsLanguage> + AsFormat,
 {
     fn fmt(&self, f: &mut JsFormatter) -> FormatResult<()> {
         let snapshot = Formatter::state_snapshot(f);

crates/rome_js_formatter/src/cst.rs

@@ -15,10 +15,10 @@ impl rome_formatter::FormatRule<JsSyntaxNode> for FormatJsSyntaxNode {
     }
 }
 
-impl<'a> AsFormat<'a> for JsSyntaxNode {
-    type Format = FormatRefWithRule<'a, JsSyntaxNode, FormatJsSyntaxNode>;
+impl AsFormat for JsSyntaxNode {
+    type Format<'a> = FormatRefWithRule<'a, JsSyntaxNode, FormatJsSyntaxNode>;
 
-    fn format(&'a self) -> Self::Format {
+    fn format(&self) -> Self::Format<'_> {
         FormatRefWithRule::new(self, FormatJsSyntaxNode)
     }
 }