feat(rome_js_analyze): promote rules (#3471)

rome · Nov 1, 2022 · 22dd11d · 22dd11d
1 parent 5953607
commit 22dd11d
Show file tree

Hide file tree

Showing 284 changed files with 2,453 additions and 1,791 deletions.
diff --git a/crates/rome_cli/tests/commands/check.rs b/crates/rome_cli/tests/commands/check.rs
@@ -57,13 +57,9 @@ const JS_ERRORS_AFTER: &str = "try {
 }
 ";
 
-const NO_DEAD_CODE_ERROR: &str = r#"function f() {
-    for (;;) {
-        continue;
-        break;
-    }
-}
-"#;
+const UPGRADE_SEVERITY_CODE: &str = r#"class A extends B {
+    constructor() {}
+}"#;
 
 #[test]
 fn ok() {
@@ -542,7 +538,7 @@ fn upgrade_severity() {
     );
 
     let file_path = Path::new("file.js");
-    fs.insert(file_path.into(), NO_DEAD_CODE_ERROR.as_bytes());
+    fs.insert(file_path.into(), UPGRADE_SEVERITY_CODE.as_bytes());
 
     let result = run_cli(
         DynRef::Borrowed(&mut fs),
@@ -554,24 +550,14 @@ fn upgrade_severity() {
 
     let messages = &console.out_buffer;
 
+    dbg!(&result);
     assert_eq!(
         messages
             .iter()
             .filter(|m| m.level == LogLevel::Error)
             .filter(|m| {
                 let content = format!("{:?}", m.content);
-                content.contains("nursery/noUnreachable")
-            })
-            .count(),
-        1
-    );
-    assert_eq!(
-        messages
-            .iter()
-            .filter(|m| m.level == LogLevel::Error)
-            .filter(|m| {
-                let content = format!("{:?}", m.content);
-                content.contains("nursery/noUnusedVariables")
+                content.contains("nursery/noInvalidConstructorSuper")
             })
             .count(),
         1

diff --git a/crates/rome_cli/tests/configs.rs b/crates/rome_cli/tests/configs.rs
@@ -35,17 +35,19 @@ pub const CONFIG_ALL_FIELDS: &str = r#"{
   "linter": {
     "enabled": true,
     "rules": {
+        "complexity": {
+            "useSimplifiedLogicExpression": "warn"
+        },
+        "style": {        
+            "useTemplate": {
+                "level": "error"
+            }
+        },
         "correctness": {
-            "useSimplifiedLogicExpression": "warn",
             "noCatchAssign": "error",
             "noLabelVar": {
                 "level": "warn"
             },
-            "useTemplate": {
-                "level": "error"
-            }
-        },
-        "nursery": {
             "noUnreachable": "off"
         }
     }
@@ -121,7 +123,6 @@ pub const CONFIG_LINTER_DOWNGRADE_DIAGNOSTIC: &str = r#"{
     "rules": {
         "recommended": true,
         "correctness": {
-            "recommended": true,      
             "noDebugger": "warn"
         }
     }
@@ -133,8 +134,7 @@ pub const CONFIG_LINTER_UPGRADE_DIAGNOSTIC: &str = r#"{
     "rules": {
         "recommended": true,
         "nursery": {
-            "noUnreachable": "error",
-            "noUnusedVariables": "error"
+            "noInvalidConstructorSuper": "error"
         }
     }
   }

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/downgrade_severity.snap b/crates/rome_cli/tests/snapshots/main_commands_check/downgrade_severity.snap
@@ -10,7 +10,6 @@ expression: content
     "rules": {
         "recommended": true,
         "correctness": {
-            "recommended": true,      
             "noDebugger": "warn"
         }
     }

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/lint_error.snap b/crates/rome_cli/tests/snapshots/main_commands_check/lint_error.snap
@@ -18,36 +18,36 @@ errors where emitted while running checks
 # Emitted Messages
 
 ```block
-check.js:1:1 lint/correctness/useBlockStatements  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+check.js:1:1 lint/correctness/useWhile  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Block statements are preferred in this position.
+  × Use while loops instead of for loops.
   
   > 1 │ for(;true;);
-      │ ^^^^^^^^^^^^
+      │ ^^^^^^^^^^^
     2 │ 
   
-  i Suggested fix: Wrap the statement with a `JsBlockStatement`
+  i Suggested fix: Use a while loop
   
     1   │ - for(;true;);
-      1 │ + for(;true;)·{}
+      1 │ + while·(true);
     2 2 │   
   
 
 ```
 
 ```block
-check.js:1:1 lint/correctness/useWhile  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+check.js:1:1 lint/style/useBlockStatements  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Use while loops instead of for loops.
+  × Block statements are preferred in this position.
   
   > 1 │ for(;true;);
-      │ ^^^^^^^^^^^
+      │ ^^^^^^^^^^^^
     2 │ 
   
-  i Suggested fix: Use a while loop
+  i Suggested fix: Wrap the statement with a `JsBlockStatement`
   
     1   │ - for(;true;);
-      1 │ + while·(true);
+      1 │ + for(;true;)·{}
     2 2 │