chore: apply suggestions

rome · Mar 1, 2023 · 285c963 · 285c963
1 parent 13ffd85
commit 285c963
Show file tree

Hide file tree

Showing 39 changed files with 537 additions and 420 deletions.
diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/fs_error_dereferenced_symlink.snap b/crates/rome_cli/tests/snapshots/main_commands_check/fs_error_dereferenced_symlink.snap
@@ -15,6 +15,51 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 
 # Emitted Messages
 
+```block
+Found errors in the configuration file, Rome will use its defaults for the sections that are incorrect.
+```
+
+```block
+/Users/ema/www/tools/rome.json:20:5 configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Found an unknown key `noNonNullAssertion`
+  
+    18 │ 			"recommended": true,
+    19 │ 			"suspicious": {
+  > 20 │ 				"noNonNullAssertion": "off"
+       │ 				^^^^^^^^^^^^^^^^^^^^
+    21 │ 			}
+    22 │ 		}
+  
+  i Accepted keys
+  
+  - recommended
+  - noArrayIndexKey
+  - noAsyncPromiseExecutor
+  - noCatchAssign
+  - noCommentText
+  - noCompareNegZero
+  - noConstEnum
+  - noDebugger
+  - noDoubleEquals
+  - noDuplicateObjectKeys
+  - noDuplicateParameters
+  - noEmptyInterface
+  - noExplicitAny
+  - noExtraNonNullAssertion
+  - noFunctionAssign
+  - noImportAssign
+  - noLabelVar
+  - noRedundantUseStrict
+  - noShadowRestrictedNames
+  - noSparseArray
+  - noUnsafeNegation
+  - useDefaultSwitchClauseLast
+  - useValidTypeof
+  
+
+```
+
 ```block
 <TEMP_DIR>/rome_test_broken_symlink/broken_symlink internalError/fs ━━━━━━━━━━━━━━━━━━━━
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/fs_error_infinite_symlink_expansion.snap b/crates/rome_cli/tests/snapshots/main_commands_check/fs_error_infinite_symlink_expansion.snap
@@ -15,6 +15,51 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 
 # Emitted Messages
 
+```block
+Found errors in the configuration file, Rome will use its defaults for the sections that are incorrect.
+```
+
+```block
+/Users/ema/www/tools/rome.json:20:5 configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Found an unknown key `noNonNullAssertion`
+  
+    18 │ 			"recommended": true,
+    19 │ 			"suspicious": {
+  > 20 │ 				"noNonNullAssertion": "off"
+       │ 				^^^^^^^^^^^^^^^^^^^^
+    21 │ 			}
+    22 │ 		}
+  
+  i Accepted keys
+  
+  - recommended
+  - noArrayIndexKey
+  - noAsyncPromiseExecutor
+  - noCatchAssign
+  - noCommentText
+  - noCompareNegZero
+  - noConstEnum
+  - noDebugger
+  - noDoubleEquals
+  - noDuplicateObjectKeys
+  - noDuplicateParameters
+  - noEmptyInterface
+  - noExplicitAny
+  - noExtraNonNullAssertion
+  - noFunctionAssign
+  - noImportAssign
+  - noLabelVar
+  - noRedundantUseStrict
+  - noShadowRestrictedNames
+  - noSparseArray
+  - noUnsafeNegation
+  - useDefaultSwitchClauseLast
+  - useValidTypeof
+  
+
+```
+
 ```block
 <TEMP_DIR>/rome_test_infinite_symlink_exapansion/prefix internalError/fs ━━━━━━━━━━━━━━━━━━━━
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/should_disable_a_rule_group.snap b/crates/rome_cli/tests/snapshots/main_commands_check/should_disable_a_rule_group.snap
@@ -30,12 +30,6 @@ try {
 
 # Emitted Messages
 
-```block
-Skipped 1 suggested fixes.
-If you wish to apply the suggested (unsafe) fixes, use the command rome check --apply-unsafe
-
-```
-
 ```block
 Fixed 1 file(s) in <TIME>
 ```

diff --git a/...es/rome_cli/tests/snapshots/main_commands_ci/ci_runs_linter_not_formatter_issue_3495.snap b/...es/rome_cli/tests/snapshots/main_commands_ci/ci_runs_linter_not_formatter_issue_3495.snap
@@ -32,22 +32,6 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 
 # Emitted Messages
 
-```block
-file.js:1:9 lint/complexity/useSimplifiedLogicExpression  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  × Logical expression contains unnecessary complexity.
-  
-  > 1 │ let a = !b || !c
-      │         ^^^^^^^^
-  
-  i Suggested fix: Reduce the complexity of the logical expression.
-  
-  - let·a·=·!b·||·!c
-  + let·a·=·!(b·&&·c)
-  
-
-```
-
 ```block
 file.js:1:1 lint/style/useConst  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 

diff --git a/crates/rome_cli/tests/snapshots/main_configuration/incorrect_rule_name.snap b/crates/rome_cli/tests/snapshots/main_configuration/incorrect_rule_name.snap
@@ -55,11 +55,11 @@ rome.json:6:13 configuration ━━━━━━━━━━━━━━━━━
   - noChildrenProp
   - noConstAssign
   - noConstructorReturn
-  - noDuplicateObjectKeys
   - noEmptyPattern
   - noNewSymbol
   - noPrecisionLoss
   - noRenderReturnValue
+  - noSetterReturn
   - noStringCaseMismatch
   - noUndeclaredVariables
   - noUnnecessaryContinue
@@ -68,7 +68,6 @@ rome.json:6:13 configuration ━━━━━━━━━━━━━━━━━
   - noUnusedVariables
   - noVoidElementsWithChildren
   - noVoidTypeReturn
-  - useEnumInitializers
   - useValidForDirection
   
 

diff --git a/crates/rome_diagnostics_categories/src/categories.rs b/crates/rome_diagnostics_categories/src/categories.rs
@@ -45,12 +45,11 @@ define_categories! {
     "lint/correctness/noVoidElementsWithChildren": "https://docs.rome.tools/lint/rules/noVoidElementsWithChildren",
     "lint/correctness/useValidForDirection": "https://docs.rome.tools/lint/rules/useValidForDirection",
     "lint/correctness/noUnsafeFinally": "https://docs.rome.tools/lint/rules/noUnsafeFinally",
-    "lint/correctness/noDuplicateObjectKeys":"https://docs.rome.tools/lint/rules/noDuplicateObjectKeys",
     "lint/correctness/noConstructorReturn": "https://docs.rome.tools/lint/rules/noConstructorReturn",
-    "lint/correctness/useEnumInitializers":"https://docs.rome.tools/lint/rules/useEnumInitializers",
     "lint/correctness/noPrecisionLoss": "https://docs.rome.tools/lint/rules/noPrecisionLoss",
     "lint/correctness/noVoidTypeReturn": "https://docs.rome.tools/lint/rules/noVoidTypeReturn",
     "lint/correctness/noStringCaseMismatch": "https://docs.rome.tools/lint/rules/noStringCaseMismatch",
+    "lint/correctness/noSetterReturn": "https://docs.rome.tools/lint/rules/noSetterReturn",
 
 
     // nursery
@@ -126,6 +125,9 @@ define_categories! {
     "lint/style/useDefaultParameterLast":"https://docs.rome.tools/lint/rules/useDefaultParameterLast",
     "lint/style/useConst":"https://docs.rome.tools/lint/rules/useConst",
     "lint/style/noVar": "https://docs.rome.tools/lint/rules/noVar",
+    "lint/style/noNonNullAssertion": "https://docs.rome.tools/lint/rules/noNonNullAssertion",
+    "lint/style/useEnumInitializers":"https://docs.rome.tools/lint/rules/useEnumInitializers",
+
 
     // suspicious
     "lint/suspicious/noArrayIndexKey": "https://docs.rome.tools/lint/rules/noArrayIndexKey",
@@ -147,10 +149,10 @@ define_categories! {
     "lint/suspicious/noEmptyInterface": "https://docs.rome.tools/lint/rules/noEmptyInterface",
     "lint/suspicious/noExtraNonNullAssertion":"https://docs.rome.tools/lint/rules/noExtraNonNullAssertion",
     "lint/suspicious/noRedundantUseStrict": "https://docs.rome.tools/lint/rules/noRedundantUseStrict",
-    "lint/suspicious/noNonNullAssertion": "https://docs.rome.tools/lint/rules/noNonNullAssertion",
     "lint/suspicious/noConstEnum": "https://docs.rome.tools/lint/rules/noConstEnum",
-    "lint/suspicious/noSetterReturn": "https://docs.rome.tools/lint/rules/noSetterReturn",
     "lint/suspicious/useDefaultSwitchClauseLast":"https://docs.rome.tools/lint/rules/useDefaultSwitchClauseLast",
+    "lint/suspicious/noDuplicateObjectKeys":"https://docs.rome.tools/lint/rules/noDuplicateObjectKeys",
+
 
 
     ;

diff --git a/crates/rome_js_analyze/src/analyzers/complexity/use_simplified_logic_expression.rs b/crates/rome_js_analyze/src/analyzers/complexity/use_simplified_logic_expression.rs
@@ -49,7 +49,7 @@ declare_rule! {
     pub(crate) UseSimplifiedLogicExpression {
         version: "0.7.0",
         name: "useSimplifiedLogicExpression",
-        recommended: true,
+        recommended: false,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/correctness.rs b/crates/rome_js_analyze/src/analyzers/correctness.rs
diff --git a/.../analyzers/suspicious/no_setter_return.rs → ...analyzers/correctness/no_setter_return.rs b/.../analyzers/suspicious/no_setter_return.rs → ...analyzers/correctness/no_setter_return.rs
diff --git a/crates/rome_js_analyze/src/analyzers/style.rs b/crates/rome_js_analyze/src/analyzers/style.rs
diff --git a/...yzers/suspicious/no_non_null_assertion.rs → .../analyzers/style/no_non_null_assertion.rs b/...yzers/suspicious/no_non_null_assertion.rs → .../analyzers/style/no_non_null_assertion.rs
diff --git a/...zers/correctness/use_enum_initializers.rs → .../analyzers/style/use_enum_initializers.rs b/...zers/correctness/use_enum_initializers.rs → .../analyzers/style/use_enum_initializers.rs
diff --git a/crates/rome_js_analyze/src/analyzers/suspicious.rs b/crates/rome_js_analyze/src/analyzers/suspicious.rs
diff --git a/...s/correctness/no_duplicate_object_keys.rs → ...rs/suspicious/no_duplicate_object_keys.rs b/...s/correctness/no_duplicate_object_keys.rs → ...rs/suspicious/no_duplicate_object_keys.rs
diff --git a/...pecs/suspicious/noSetterReturn/invalid.js → ...ecs/correctness/noSetterReturn/invalid.js b/...pecs/suspicious/noSetterReturn/invalid.js → ...ecs/correctness/noSetterReturn/invalid.js