fix(rome_js_analyzer): #3261

rome · Sep 21, 2022 · 4caeb45 · 4caeb45
1 parent de1392c
commit 4caeb45
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 5 deletions.
diff --git a/crates/rome_js_analyze/src/lib.rs b/crates/rome_js_analyze/src/lib.rs
@@ -112,9 +112,9 @@ mod tests {
     #[test]
     fn quick_test() {
         const SOURCE: &str = r#"
-React.createElement('button', {
-    "type": "bar"
-});
+function Component() {}
+const f = <Component>ff</Component>;
+f()
         "#;
 
         let parsed = parse(SOURCE, FileId::zero(), SourceType::jsx());

diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs
@@ -13,7 +13,7 @@ use rome_js_syntax::{
     JsFormalParameter, JsFunctionDeclaration, JsFunctionExportDefaultDeclaration,
     JsGetterClassMember, JsIdentifierBinding, JsLiteralMemberName, JsMethodClassMember,
     JsPrivateClassMemberName, JsPropertyClassMember, JsSetterClassMember, JsSyntaxKind,
-    JsVariableDeclaration, JsVariableDeclarator, JsVariableDeclaratorList,
+    JsVariableDeclaration, JsVariableDeclarator, JsVariableDeclaratorList, JsxReferenceIdentifier,
 };
 use rome_rowan::{declare_node_union, AstNode, BatchMutationExt};
 use std::{borrow::Cow, iter::once};
@@ -118,8 +118,14 @@ impl Rule for UseCamelCase {
                         let is_exported_function = binding
                             .parent::<JsFunctionExportDefaultDeclaration>()
                             .is_some();
+                        let is_jsx_component = model.all_reads(binding).any(|reference| {
+                            JsxReferenceIdentifier::can_cast(reference.node().kind())
+                        });
 
-                        if is_variable || is_parameter || is_function || is_exported_function {
+                        if is_jsx_component {
+                            None
+                        } else if is_variable || is_parameter || is_function || is_exported_function
+                        {
                             let name = binding.name_token().ok()?;
                             check_is_camel(name.text_trimmed())
                         } else {

diff --git a/...alyze/tests/specs/nursery/useCamelCase.js → ...pecs/nursery/useCamelCase/useCamelCase.js b/...alyze/tests/specs/nursery/useCamelCase.js → ...pecs/nursery/useCamelCase/useCamelCase.js
diff --git a/.../tests/specs/nursery/useCamelCase.js.snap → ...nursery/useCamelCase/useCamelCase.js.snap b/.../tests/specs/nursery/useCamelCase.js.snap → ...nursery/useCamelCase/useCamelCase.js.snap
diff --git a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx
@@ -0,0 +1,3 @@
+// valid
+function Component() {}
+<Component>foo</Component>
diff --git a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap
@@ -0,0 +1,12 @@
+---
+source: crates/rome_js_analyze/tests/spec_tests.rs
+expression: useCamelCase.jsx
+---
+# Input
+```js
+// valid
+function Component() {}
+<Component>foo</Component>
+```
+
+