feat(rome_cli): rename --apply-suggested to --apply-unsafe (#4078)

rome · Dec 21, 2022 · 5da1059 · 5da1059
1 parent 162c436
commit 5da1059
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/crates/rome_cli/src/commands/check.rs b/crates/rome_cli/src/commands/check.rs
@@ -15,12 +15,12 @@ pub(crate) fn check(mut session: CliSession) -> Result<(), CliDiagnostic> {
         .update_settings(UpdateSettingsParams { configuration })?;
 
     let apply = session.args.contains("--apply");
-    let apply_suggested = session.args.contains("--apply-suggested");
+    let apply_suggested = session.args.contains("--apply-unsafe");
 
     let fix_file_mode = if apply && apply_suggested {
         return Err(CliDiagnostic::incompatible_arguments(
             "--apply",
-            "--apply-suggested",
+            "--apply-unsafe",
         ));
     } else if !apply && !apply_suggested {
         None

diff --git a/crates/rome_cli/src/commands/help.rs b/crates/rome_cli/src/commands/help.rs
@@ -35,7 +35,7 @@ const CHECK: Markup = markup! {
 
 "<Emphasis>"OPTIONS:"</Emphasis>"
     "<Dim>"--apply"</Dim>"                       Apply safe fixes
-    "<Dim>"--apply-suggested"</Dim>"             Apply safe and suggested fixes
+    "<Dim>"--apply-unsafe"</Dim>"                Apply safe and unsafe fixes
     "<Dim>"--max-diagnostics"</Dim>"             Cap the amount of diagnostics displayed (default: 20)
     "<Dim>"--verbose"</Dim>"                     Print additional verbose advices on diagnostics
 "

diff --git a/crates/rome_cli/src/traversal.rs b/crates/rome_cli/src/traversal.rs
@@ -569,7 +569,7 @@ fn process_messages(options: ProcessMessagesOptions) {
     if mode.is_check() && total_skipped_suggested_fixes > 0 {
         console.log(markup! {
             <Warn>"Skipped "{total_skipped_suggested_fixes}" suggested fixes.\n"</Warn>
-            <Info>"If you wish to apply the suggested fixes, use the command "<Emphasis>"rome check --apply-suggested\n"</Emphasis></Info>
+            <Info>"If you wish to apply the suggested (unsafe) fixes, use the command "<Emphasis>"rome check --apply-unsafe\n"</Emphasis></Info>
         })
     }
 

diff --git a/crates/rome_cli/tests/commands/check.rs b/crates/rome_cli/tests/commands/check.rs
@@ -278,7 +278,7 @@ fn apply_suggested_error() {
         &mut console,
         Arguments::from_vec(vec![
             OsString::from("check"),
-            OsString::from("--apply-suggested"),
+            OsString::from("--apply-unsafe"),
             OsString::from("--apply"),
             file_path.as_os_str().into(),
         ]),
@@ -308,7 +308,7 @@ fn apply_suggested() {
         &mut console,
         Arguments::from_vec(vec![
             OsString::from("check"),
-            OsString::from("--apply-suggested"),
+            OsString::from("--apply-unsafe"),
             file_path.as_os_str().into(),
         ]),
     );

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/apply_noop.snap b/crates/rome_cli/tests/snapshots/main_commands_check/apply_noop.snap
@@ -14,7 +14,7 @@ if(a != 0) {}
 
 ```block
 Skipped 1 suggested fixes.
-If you wish to apply the suggested fixes, use the command rome check --apply-suggested
+If you wish to apply the suggested (unsafe) fixes, use the command rome check --apply-unsafe
 
 ```
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/apply_ok.snap b/crates/rome_cli/tests/snapshots/main_commands_check/apply_ok.snap
@@ -14,7 +14,7 @@ if(a != 0) {}
 
 ```block
 Skipped 1 suggested fixes.
-If you wish to apply the suggested fixes, use the command rome check --apply-suggested
+If you wish to apply the suggested (unsafe) fixes, use the command rome check --apply-unsafe
 
 ```
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/apply_suggested_error.snap b/crates/rome_cli/tests/snapshots/main_commands_check/apply_suggested_error.snap
@@ -16,7 +16,7 @@ console.log(a);
 ```block
 flags/invalid ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  × Incompatible arguments --apply and --apply-suggested
+  × Incompatible arguments --apply and --apply-unsafe
   
 
 

diff --git a/crates/rome_cli/tests/snapshots/main_commands_check/should_disable_a_rule_group.snap b/crates/rome_cli/tests/snapshots/main_commands_check/should_disable_a_rule_group.snap
@@ -32,7 +32,7 @@ try {
 
 ```block
 Skipped 1 suggested fixes.
-If you wish to apply the suggested fixes, use the command rome check --apply-suggested
+If you wish to apply the suggested (unsafe) fixes, use the command rome check --apply-unsafe
 
 ```