feat: add support for double keywords in assertion

crates/rome_js_parser/src/parse.rs

@@ -262,6 +262,8 @@ pub fn parse_js_with_cache(
     tracing::debug_span!("parse").in_scope(move || {
         let (events, errors, tokens) = parse_common(text, source_type);
         let mut tree_sink = JsLosslessTreeSink::with_cache(text, &tokens, cache);
+        dbg!(&tree_sink);
+        dbg!(&events);
         rome_parser::event::process(&mut tree_sink, events, errors);
         let (green, parse_errors) = tree_sink.finish();
         Parse::new(green, parse_errors)

crates/rome_js_parser/src/syntax/module.rs

@@ -539,6 +539,15 @@ fn parse_any_named_import_specifier(p: &mut JsParser) -> ParsedSyntax {
 // import "x" assert
 // { type: "json" }
 
+// test import_attribute
+// import "x" with { type: "json" }
+// import "foo" with { "type": "json" };
+// import foo from "foo.json" with { type: "json" };
+// import {test} from "foo.json" with { for: "for" }
+// import foo_json from "foo.json" with { type: "json", hasOwnProperty: "true" };
+// import "x" with
+// { type: "json" }
+
 // test_err import_assertion_err
 // import "foo" assert { type, "json" };
 // import "bar" \u{61}ssert { type: "json" };
@@ -549,15 +558,40 @@ fn parse_any_named_import_specifier(p: &mut JsParser) -> ParsedSyntax {
 // import "x" assert;
 // import ipsum from "ipsum.json" assert { type: "json", lazy: true, startAtLine: 1 };
 // import { a } from "a.json" assert
+
+// test_err import_attribute_err
+// import "foo" with { type, "json" };
+// import { foo } with { type: "json" };
+// import "lorem"
+// assert { type: "json" }
+// import foo2 from "foo.json" with { "type": "json", type: "html", "type": "js" };
+// import "x" with;
+// import ipsum from "ipsum.json" with { type: "json", lazy: true, startAtLine: 1 };
+// import { a } from "a.json" with
 fn parse_import_assertion(p: &mut JsParser) -> ParsedSyntax {
-    if !p.at(T![assert]) || p.has_preceding_line_break() {
+    if p.has_preceding_line_break() {
+        return Absent;
+    }
+    if !p.at(T![assert]) && !p.at(T![with]) {
         return Absent;
     }
 
     let m = p.start();
-    p.expect(T![assert]);
-    p.expect(T!['{']);
+    match p.cur() {
+        T![assert] => {
+            p.expect(T![assert]);
+        }
+        T![with] => {
+            p.expect(T![with]);
+        }
+        _ => {
+            m.abandon(p);
+            return Absent;
+        }
+    };
 
+    // bump assert or with
+    p.expect(T!['{']);
     ImportAssertionList::default().parse_list(p);
 
     p.expect(T!['}']);

crates/rome_js_parser/src/tests.rs

@@ -14,9 +14,7 @@ use std::path::{Path, PathBuf};
 #[test]
 fn parser_smoke_test() {
     let src = r#"
-let
-// comment
-a;
+import "x" with { type: "json" }
 "#;
 
     let module = parse(src, JsFileSource::tsx());

crates/rome_js_parser/test_data/inline/err/import_assertion_err.rast

@@ -9,7 +9,7 @@ JsModule {
                     value_token: JS_STRING_LITERAL@7..13 "\"foo\"" [] [Whitespace(" ")],
                 },
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@13..20 "assert" [] [Whitespace(" ")],
+                    assertion: ASSERT_KW@13..20 "assert" [] [Whitespace(" ")],
                     l_curly_token: L_CURLY@20..22 "{" [] [Whitespace(" ")],
                     assertions: JsImportAssertionEntryList [
                         JsImportAssertionEntry {
@@ -76,7 +76,7 @@ JsModule {
                 from_token: missing (required),
                 source: missing (required),
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@96..103 "assert" [] [Whitespace(" ")],
+                    assertion: ASSERT_KW@96..103 "assert" [] [Whitespace(" ")],
                     l_curly_token: L_CURLY@103..105 "{" [] [Whitespace(" ")],
                     assertions: JsImportAssertionEntryList [
                         JsImportAssertionEntry {
@@ -136,7 +136,7 @@ JsModule {
                     value_token: JS_STRING_LITERAL@177..188 "\"foo.json\"" [] [Whitespace(" ")],
                 },
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@188..195 "assert" [] [Whitespace(" ")],
+                    assertion: ASSERT_KW@188..195 "assert" [] [Whitespace(" ")],
                     l_curly_token: L_CURLY@195..197 "{" [] [Whitespace(" ")],
                     assertions: JsImportAssertionEntryList [
                         JsImportAssertionEntry {
@@ -173,7 +173,7 @@ JsModule {
                     value_token: JS_STRING_LITERAL@250..254 "\"x\"" [] [Whitespace(" ")],
                 },
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@254..260 "assert" [] [],
+                    assertion: ASSERT_KW@254..260 "assert" [] [],
                     l_curly_token: missing (required),
                     assertions: JsImportAssertionEntryList [],
                     r_curly_token: missing (required),
@@ -193,7 +193,7 @@ JsModule {
                     value_token: JS_STRING_LITERAL@280..293 "\"ipsum.json\"" [] [Whitespace(" ")],
                 },
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@293..300 "assert" [] [Whitespace(" ")],
+                    assertion: ASSERT_KW@293..300 "assert" [] [Whitespace(" ")],
                     l_curly_token: L_CURLY@300..302 "{" [] [Whitespace(" ")],
                     assertions: JsImportAssertionEntryList [
                         JsImportAssertionEntry {
@@ -253,7 +253,7 @@ JsModule {
                     value_token: JS_STRING_LITERAL@364..373 "\"a.json\"" [] [Whitespace(" ")],
                 },
                 assertion: JsImportAssertion {
-                    assert_token: ASSERT_KW@373..379 "assert" [] [],
+                    assertion: ASSERT_KW@373..379 "assert" [] [],
                     l_curly_token: missing (required),
                     assertions: JsImportAssertionEntryList [],
                     r_curly_token: missing (required),

crates/rome_js_parser/test_data/inline/err/import_attribute_err.js

@@ -0,0 +1,8 @@
+import "foo" with { type, "json" };
+import { foo } with { type: "json" };
+import "lorem"
+assert { type: "json" }
+import foo2 from "foo.json" with { "type": "json", type: "html", "type": "js" };
+import "x" with;
+import ipsum from "ipsum.json" with { type: "json", lazy: true, startAtLine: 1 };
+import { a } from "a.json" with