chore: promote more rules, review groups

rome · Oct 25, 2022 · a0cc990 · a0cc990
1 parent 6366190
commit a0cc990
Show file tree

Hide file tree

Showing 148 changed files with 1,102 additions and 800 deletions.
diff --git a/crates/rome_diagnostics_categories/src/categories.rs b/crates/rome_diagnostics_categories/src/categories.rs
@@ -20,7 +20,6 @@ define_dategories! {
     "lint/correctness/noDoubleEquals": "https://rome.tools/docs/lint/rules/noDoubleEquals",
     "lint/correctness/noDupeArgs": "https://rome.tools/docs/lint/rules/noDupeArgs",
     "lint/correctness/noEmptyPattern": "https://rome.tools/docs/lint/rules/noEmptyPattern",
-    "lint/correctness/noExtraBooleanCast": "https://rome.tools/docs/lint/rules/noExtraBooleanCast",
     "lint/correctness/noFunctionAssign": "https://rome.tools/docs/lint/rules/noFunctionAssign",
     "lint/correctness/noImplicitBoolean": "https://rome.tools/docs/lint/rules/noImplicitBoolean",
     "lint/correctness/noImportAssign": "https://rome.tools/docs/lint/rules/noImportAssign",
@@ -36,43 +35,50 @@ define_dategories! {
     "lint/correctness/useSingleVarDeclarator": "https://rome.tools/docs/lint/rules/useSingleVarDeclarator",
     "lint/correctness/useValidTypeof": "https://rome.tools/docs/lint/rules/useValidTypeof",
     "lint/correctness/useWhile": "https://rome.tools/docs/lint/rules/useWhile",
-    "lint/correctness/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
     "lint/correctness/noNewSymbol": "https://rome.tools/docs/lint/rules/noNewSymbol",
-    "lint/correctness/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
     "lint/correctness/noUselessFragments": "https://rome.tools/docs/lint/rules/noUselessFragments",
-    "lint/correctness/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
-    "lint/correctness/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
-    "lint/correctness/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
-    "lint/correctness/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
-    "lint/correctness/noAutofocus": "https://rome.tools/docs/lint/rules/noAutofocus",
+    "lint/correctness/noUnusedVariables": "https://rome.tools/docs/lint/rules/noUnusedVariables",
+    "lint/correctness/noUnreachable": "https://rome.tools/docs/lint/rules/noUnreachable",
+    "lint/correctness/noRestrictedGlobals": "https://rome.tools/docs/lint/rules/noRestrictedGlobals",
+    "lint/correctness/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
+    "lint/correctness/noUndeclaredVariables": "https://rome.tools/docs/lint/rules/noUndeclaredVariables",
+
     // style category
     "lint/style/noNegationElse": "https://rome.tools/docs/lint/rules/noNegationElse",
     "lint/style/noShoutyConstants": "https://rome.tools/docs/lint/rules/noShoutyConstants",
     "lint/style/useSelfClosingElements": "https://rome.tools/docs/lint/rules/useSelfClosingElements",
     "lint/style/useShorthandArrayType": "https://rome.tools/docs/lint/rules/useShorthandArrayType",
     "lint/style/useFragmentSyntax": "https://rome.tools/docs/lint/rules/useFragmentSyntax",
     "lint/style/useTemplate": "https://rome.tools/docs/lint/rules/useTemplate",
+    "lint/style/useCamelCase": "https://rome.tools/docs/lint/rules/useCamelCase",
+
     // complexity
     "lint/complexity/useSimplifiedLogicExpression": "https://rome.tools/docs/lint/rules/useSimplifiedLogicExpression",
+    "lint/complexity/noExtraBooleanCast": "https://rome.tools/docs/lint/rules/noExtraBooleanCast",
 
     // a11y category
+    "lint/a11y/noAutofocus": "https://rome.tools/docs/lint/rules/noAutofocus",
     "lint/a11y/noPositiveTabindex": "https://rome.tools/docs/lint/rules/noPositiveTabindex",
     "lint/a11y/useKeyWithMouseEvents": "https://rome.tools/docs/lint/rules/useKeyWithMouseEvents",
     "lint/a11y/useAnchorContent": "https://rome.tools/docs/lint/rules/useAnchorContent",
     "lint/a11y/useBlankTarget": "https://rome.tools/docs/lint/rules/useBlankTarget",
     "lint/a11y/useValidAnchor": "https://rome.tools/docs/lint/rules/useValidAnchor",
     "lint/a11y/useKeyWithClickEvents": "https://rome.tools/docs/lint/rules/useKeyWithClickEvents",
     "lint/a11y/useButtonType": "https://rome.tools/docs/lint/rules/useButtonType",
+    // react
+    "lint/react/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
+    "lint/react/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
+    "lint/react/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
+    "lint/react/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
+    "lint/react/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
+    "lint/react/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
+
+
+
     // nursery
-    "lint/nursery/noRestrictedGlobals": "https://rome.tools/docs/lint/rules/noRestrictedGlobals",
     "lint/nursery/useFlatMap": "https://rome.tools/docs/lint/rules/useFlatMap",
     "lint/nursery/noConstAssign": "https://rome.tools/docs/lint/rules/noConstAssign",
     "lint/nursery/noExplicitAny": "https://rome.tools/docs/lint/rules/noExplicitAny",
-    "lint/nursery/useCamelCase": "https://rome.tools/docs/lint/rules/useCamelCase",
-    "lint/nursery/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
-    "lint/nursery/noUndeclaredVariables": "https://rome.tools/docs/lint/rules/noUndeclaredVariables",
-    "lint/nursery/noUnreachable": "https://rome.tools/docs/lint/rules/noUnreachable",
-    "lint/nursery/noUnusedVariables": "https://rome.tools/docs/lint/rules/noUnusedVariables",
     "lint/nursery/useValidForDirection": "https://rome.tools/docs/lint/rules/useValidForDirection",
     ;
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y.rs b/crates/rome_js_analyze/src/analyzers/a11y.rs
diff --git a/...rc/analyzers/correctness/no_auto_focus.rs → ...alyze/src/analyzers/a11y/no_auto_focus.rs b/...rc/analyzers/correctness/no_auto_focus.rs → ...alyze/src/analyzers/a11y/no_auto_focus.rs
diff --git a/crates/rome_js_analyze/src/analyzers/complexity.rs b/crates/rome_js_analyze/src/analyzers/complexity.rs
diff --git a/...zers/correctness/no_extra_boolean_cast.rs → ...yzers/complexity/no_extra_boolean_cast.rs b/...zers/correctness/no_extra_boolean_cast.rs → ...yzers/complexity/no_extra_boolean_cast.rs
diff --git a/crates/rome_js_analyze/src/analyzers/correctness.rs b/crates/rome_js_analyze/src/analyzers/correctness.rs
diff --git a/...e/src/analyzers/nursery/no_unreachable.rs → ...c/analyzers/correctness/no_unreachable.rs b/...e/src/analyzers/nursery/no_unreachable.rs → ...c/analyzers/correctness/no_unreachable.rs
diff --git a/...c/analyzers/nursery/use_optional_chain.rs → ...alyzers/correctness/use_optional_chain.rs b/...c/analyzers/nursery/use_optional_chain.rs → ...alyzers/correctness/use_optional_chain.rs
diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers.rs b/crates/rome_js_analyze/src/semantic_analyzers.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs b/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs
diff --git a/...nalyzers/nursery/no_restricted_globals.rs → ...zers/correctness/no_restricted_globals.rs b/...nalyzers/nursery/no_restricted_globals.rs → ...zers/correctness/no_restricted_globals.rs
@@ -1,10 +1,11 @@
-use crate::semantic_analyzers::nursery::no_undeclared_variables::AnyIdentifier;
 use crate::semantic_services::SemanticServices;
 use rome_analyze::context::RuleContext;
 use rome_analyze::{declare_rule, Rule, RuleDiagnostic};
 use rome_console::markup;
 use rome_js_semantic::{Binding, DeclarationExtensions};
-use rome_js_syntax::{JsReferenceIdentifier, JsxReferenceIdentifier, TextRange};
+use rome_js_syntax::{
+    JsIdentifierAssignment, JsReferenceIdentifier, JsxReferenceIdentifier, TextRange,
+};
 use rome_rowan::{declare_node_union, AstNode};
 
 declare_rule! {
@@ -35,7 +36,7 @@ declare_rule! {
 }
 
 declare_node_union! {
-    pub(crate) AnyReferenceIdentifier = JsReferenceIdentifier |JsxReferenceIdentifier
+    pub(crate) AnyIdentifier = JsReferenceIdentifier | JsIdentifierAssignment | JsxReferenceIdentifier
 }
 
 const RESTRICTED_GLOBALS: [&str; 2] = ["event", "error"];

diff --git a/...lyzers/nursery/no_undeclared_variables.rs → ...rs/correctness/no_undeclared_variables.rs b/...lyzers/nursery/no_undeclared_variables.rs → ...rs/correctness/no_undeclared_variables.rs
diff --git a/..._analyzers/nursery/no_unused_variables.rs → ...lyzers/correctness/no_unused_variables.rs b/..._analyzers/nursery/no_unused_variables.rs → ...lyzers/correctness/no_unused_variables.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/react.rs b/crates/rome_js_analyze/src/semantic_analyzers/react.rs
diff --git a/...alyzers/correctness/no_array_index_key.rs → ...tic_analyzers/react/no_array_index_key.rs b/...alyzers/correctness/no_array_index_key.rs → ...tic_analyzers/react/no_array_index_key.rs
diff --git a/...analyzers/correctness/no_children_prop.rs → ...antic_analyzers/react/no_children_prop.rs b/...analyzers/correctness/no_children_prop.rs → ...antic_analyzers/react/no_children_prop.rs
diff --git a/...rectness/no_dangerously_set_inner_html.rs → ...rs/react/no_dangerously_set_inner_html.rs b/...rectness/no_dangerously_set_inner_html.rs → ...rs/react/no_dangerously_set_inner_html.rs
diff --git a/...ngerously_set_inner_html_with_children.rs → ...ngerously_set_inner_html_with_children.rs b/...ngerously_set_inner_html_with_children.rs → ...ngerously_set_inner_html_with_children.rs
diff --git a/...ers/correctness/no_render_return_value.rs → ...analyzers/react/no_render_return_value.rs b/...ers/correctness/no_render_return_value.rs → ...analyzers/react/no_render_return_value.rs
diff --git a/...ectness/no_void_elements_with_children.rs → ...s/react/no_void_elements_with_children.rs b/...ectness/no_void_elements_with_children.rs → ...s/react/no_void_elements_with_children.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/style.rs b/crates/rome_js_analyze/src/semantic_analyzers/style.rs
diff --git a/...antic_analyzers/nursery/use_camel_case.rs → ...emantic_analyzers/style/use_camel_case.rs b/...antic_analyzers/nursery/use_camel_case.rs → ...emantic_analyzers/style/use_camel_case.rs