chore: clippy and regressions

rome · Dec 19, 2022 · c96d1f6 · c96d1f6
1 parent 1749623
commit c96d1f6
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/crates/rome_aria/src/roles.rs b/crates/rome_aria/src/roles.rs
@@ -698,10 +698,8 @@ impl<'a> AriaRoles {
                 _ => return false,
             };
             if let Some(mut concepts) = role.concepts_by_element_name(element_name) {
-                if concepts.any(|(name, _)| *name == element_name) {
-                    if !role.is_interactive() {
-                        return true;
-                    }
+                if concepts.any(|(name, _)| *name == element_name) && !role.is_interactive() {
+                    return true;
                 }
             }
         }

diff --git a/editors/vscode/configuration_schema.json b/editors/vscode/configuration_schema.json
diff --git a/npm/backend-jsonrpc/src/workspace.ts b/npm/backend-jsonrpc/src/workspace.ts
diff --git a/npm/rome/configuration_schema.json b/npm/rome/configuration_schema.json
diff --git a/website/src/playground/Playground.tsx b/website/src/playground/Playground.tsx
@@ -47,7 +47,6 @@ export default function PlaygroundLoader({
 	const romeOutput = file.rome;
 	const prettierOutput = file.prettier;
 
-	// rome-ignore lint/nursery/useExhaustiveDependencies: dynamic dependencies
 	const codeMirrorExtensions = useMemo(() => {
 		if (isJSONFilename(playgroundState.currentFile)) {
 			return [json()];
@@ -65,14 +64,12 @@ export default function PlaygroundLoader({
 
 	const astPanelCodeMirrorRef = useRef<null | ReactCodeMirrorRef>(null);
 
-	// rome-ignore lint/nursery/useExhaustiveDependencies: dynamic dependencies
 	useEffect(() => {
 		if (clipboardStatus !== "normal") {
 			setClipboardStatus("normal");
 		}
 	}, [romeOutput.formatter.ir]);
 
-	// rome-ignore lint/nursery/useExhaustiveDependencies: dynamic dependencies
 	const onUpdate = useCallback((viewUpdate: ViewUpdate) => {
 		const cursorPosition = viewUpdate.state.selection.ranges[0]?.from ?? 0;
 		setPlaygroundState((state) =>
@@ -127,7 +124,6 @@ export default function PlaygroundLoader({
 		});
 	}, [romeOutput.syntax.ast]);
 
-	// rome-ignore lint/nursery/useExhaustiveDependencies: dynamic dependencies
 	const onChange = useCallback((value: string) => {
 		setPlaygroundState((state) => ({
 			...state,

diff --git a/website/src/playground/components/Tabs.tsx b/website/src/playground/components/Tabs.tsx
@@ -45,6 +45,7 @@ export default function Tabs({
 								"react-tabs__tab",
 								isSelected && "react-tabs__tab--selected",
 							)}
+							// rome-ignore lint/nursery/noNoninteractiveElementToInteractiveRole: false positive?
 							role="tab"
 							aria-selected={isSelected}
 							aria-disabled={isSelected}