fix(rome_js_analyze): noPrecisionLoss correctly handle 1 digit ints

rome · Dec 21, 2022 · d38a5b6 · d38a5b6
1 parent 8d5b2ea
commit d38a5b6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/crates/rome_js_analyze/src/analyzers/nursery/no_precision_loss.rs b/crates/rome_js_analyze/src/analyzers/nursery/no_precision_loss.rs
@@ -194,13 +194,18 @@ impl NormalizedNumber<'_> {
     }
 
     fn to_scientific(&self) -> String {
-        format!(
-            "{}.{}{}e{}",
-            &self.digits[..1],
-            &self.digits[1..],
-            self.digits_rest,
-            self.exponent - 1
-        )
+        let fraction = &self.digits[1..];
+        if fraction.is_empty() && self.digits_rest.is_empty() {
+            format!("{}e{}", &self.digits[..1], self.exponent - 1)
+        } else {
+            format!(
+                "{}.{}{}e{}",
+                &self.digits[..1],
+                fraction,
+                self.digits_rest,
+                self.exponent - 1
+            )
+        }
     }
 
     fn precision(&self) -> usize {

diff --git a/crates/rome_js_analyze/tests/specs/nursery/noPrecisionLoss/valid.js b/crates/rome_js_analyze/tests/specs/nursery/noPrecisionLoss/valid.js
@@ -1,3 +1,4 @@
+var x = 1
 var x = 12345
 var x = 123.456
 var x = -123.456

diff --git a/crates/rome_js_analyze/tests/specs/nursery/noPrecisionLoss/valid.js.snap b/crates/rome_js_analyze/tests/specs/nursery/noPrecisionLoss/valid.js.snap
@@ -1,9 +1,11 @@
 ---
 source: crates/rome_js_analyze/tests/spec_tests.rs
+assertion_line: 92
 expression: valid.js
 ---
 # Input
 ```js
+var x = 1
 var x = 12345
 var x = 123.456
 var x = -123.456