Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

JSON Formatting #2570

Closed
5 of 6 tasks
Tracked by #2565
MichaReiser opened this issue May 10, 2022 · 14 comments · Fixed by #4040 or #4133
Closed
5 of 6 tasks
Tracked by #2565

JSON Formatting #2570

MichaReiser opened this issue May 10, 2022 · 14 comments · Fixed by #4040 or #4133
Labels
A-Formatter Area: formatter L-JSON Language: JSON

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented May 10, 2022 •
edited
Loading

Goal

Support formatting JSON documents

Tasks

(No comments, yay)
@MichaReiser MichaReiser mentioned this issue May 10, 2022
Closed
8 tasks
@ematipico ematipico mentioned this issue Jun 27, 2022
Closed
4 tasks
@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@MichaReiser MichaReiser added I-Staff Implementation: should be in charge of a core member of the team and removed S-Stale labels Sep 21, 2022
@dhrjarun
Copy link
Contributor

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

@MichaReiser
Copy link
Contributor Author

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

Not yet. The JSON parser isn't implemented yet, and there's some infrastructure that must be set up. I'll be working on the JSON parsing in the next few weeks, hopefully, it will be ready by December to start implementing JSON formatting.

@dhrjarun
Copy link
Contributor

ok, let me know if I could be of any help in implementing JSON parsing.

@MichaReiser MichaReiser added A-Formatter Area: formatter L-JSON Language: JSON I-Staff Implementation: should be in charge of a core member of the team and removed I-Staff Implementation: should be in charge of a core member of the team labels Nov 24, 2022
@MichaReiser
Copy link
Contributor Author

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

@dhrjarun: @denbezrukov is setting up the test infra in #3913 and you could implement array formatting after that PR lands (and @denbezrukov could work on objects)

@dhrjarun
Copy link
Contributor

dhrjarun commented Dec 2, 2022

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

@dhrjarun: @denbezrukov is setting up the test infra in #3913 and you could implement array formatting after that PR lands (and @denbezrukov could work on objects)

Sure

@MichaReiser
Copy link
Contributor Author

And #3913 is merged. Thank you @denbezrukov for your amazing work

denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 12, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting object rome#2570
581b823
@denbezrukov denbezrukov mentioned this issue Dec 12, 2022
Merged
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 12, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting object rome#2570
1559376
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 12, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting object rome#2570
436feee
MichaReiser pushed a commit that referenced this issue Dec 15, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting object #2570 (#4040)
1aee087 
Co-authored-by: Micha Reiser <micha@rome.tools>
Fix #2570
@denbezrukov
Copy link
Contributor

I guess that we need to keep it open because we still need to implement array formatting.

@ematipico ematipico reopened this Dec 16, 2022
@ematipico
Copy link
Contributor

@denbezrukov

This issue was closed because your last PR contained a magic comment:

Fix #2570 for Object value.

@ematipico ematipico removed the I-Staff Implementation: should be in charge of a core member of the team label Dec 16, 2022
@MichaReiser
Copy link
Contributor Author

@dhrjarun do you plan to work on the array formatting or are you OK if someone else starts the work?

@dhrjarun
Copy link
Contributor

@MichaReiser I will send pr tomorrow.

@dhrjarun dhrjarun mentioned this issue Dec 16, 2022
Merged
@MichaReiser
Copy link
Contributor Author

There are two more tasks. Normalization of string and number literals, similar to how it is done in the JS implementation.

@denbezrukov
Copy link
Contributor

Can I take it?

@MichaReiser
Copy link
Contributor Author

Can I take it?

Sure!

denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 22, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting number rome#2570
f6b959a
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 22, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting number rome#2570
db50bf0
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 22, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting number rome#2570
81b4ea5
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 23, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting number rome#2570
4c3272a
MichaReiser pushed a commit that referenced this issue Dec 23, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting number #2570 (#4090)
c4eb1d5
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 26, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting string rome#2570
dafeb33
denbezrukov added a commit to denbezrukov/tools that referenced this issue Dec 26, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting string rome#2570
f7989ff
MichaReiser pushed a commit that referenced this issue Dec 28, 2022
@denbezrukov
feat(rome_json_formatter): JSON Formatting string #2570 (#4105)
210b950
@MichaReiser MichaReiser linked a pull request Jan 4, 2023 that will close this issue
feat(rome_cli): Enable JSON formatting #4133
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Formatter Area: formatter L-JSON Language: JSON
Projects
Rome 2022
Status: Done
Milestone
No milestone
4 participants
@ematipico @MichaReiser @denbezrukov @dhrjarun