🐛 noNegationElse is not considering double negation

[xunilrj]

Environment information

This is the result on the branch main.

What happened?

error[js/noNegationElse]: Invert blocks when performing a negation test.
   ┌─ ./src/components/container.jsx:28:14
   │
28 │       return !!specs.variables ? specs.variables(props) : {};
   │              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Suggested fix: Exchange alternate and consequent of the node
      | @@ -25,7 +25,7 @@
24 24 |       );
25 25 |   
26 26 |       function mapPropsToVariables(props) {
27    | -       return !!specs.variables ? specs.variables(props) : {};
   27 | +       return !specs.variables ? {} : specs.variables(props);
28 28 |       }
29 29 |   
30 30 |       return class extends Component {

This is also in conflict with:

error[js/noExtraBooleanCast]: Avoid redundant double-negation.
   ┌─ ./src/components/container.jsx:28:14
   │
28 │       return !!specs.variables ? specs.variables(props) : {};
   │              ^^^^^^^^^^^^^^^^^

Suggested fix: Remove redundant double-negation
      | @@ -25,7 +25,7 @@
24 24 |       );
25 25 |   
26 26 |       function mapPropsToVariables(props) {
27    | -       return !!specs.variables ? specs.variables(props) : {};
   27 | +       return specs.variables ? specs.variables(props) : {};
28 28 |       }
29 29 |   
30 30 |       return class extends Component {

=  note: It is not necessary to use double-negation when a value will already be coerced to a boolean.

Expected result

I am not entirely sure the suggested fix is exactly the same as the original code in all cases.
And secondly, the fix would be flagged again for the same rule.

I would expect the rule to not flag anything using double negation.

Code of Conduct

• I agree to follow Rome's Code of Conduct

[github-actions]

This issue is stale because it has been open 14 days with no activity.

[github-actions]

This issue is stale because it has been open 14 days with no activity.

[github-actions]

This issue is stale because it has been open 14 days with no activity.