This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): don't check double negation in noNegationElse
#3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
xunilrj
reviewed
Oct 26, 2022
xunilrj
approved these changes
Oct 26, 2022
ematipico
force-pushed
the
fix/no-negation-else
branch
from
8ad915c
to
be79e8a
Compare
leops
reviewed
Oct 27, 2022
| ( | ||
| Some(JsUnaryOperator::LogicalNot), | ||
| Some(JsAnyExpression::JsUnaryExpression(_)), | ||
| ) => Some(false), |
There was a problem hiding this comment.
This should be checking the operator of the inner unary expression is also LogicalNot, otherwise the rule will miss cases like !-a ? b : c
There was a problem hiding this comment.
I will follow up with another PR. Thank you for the review!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3141
Test Plan
Added a new test case from the issue that was filed