This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(playground): base url not propagated to vite #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it now possible to contain the playground deploy only when the actual playground changes? |
|
I can try adding that back, although we do want to deploy when the rust code changes too, because the whole point is that you can play around with people's changes to the code with the link to the commit. So really, the only changes where we wouldn't want to deploy would be small changes to non-code or to the website. |
|
Oh yeah good point, I haven't though about it! It makes totally sense then! |
MichaReiser
approved these changes
Apr 14, 2022
Comment on lines
39
to
43
| - run: pnpm --prefix website/playground build:wasm | ||
|
|
||
| # We don't run the general build script because we need to pass in the base flag | ||
| # directly to the vite command. | ||
| - run: pnpm --prefix website/playground build:js --base=/${{ steps.sha.outputs.sha }}/ |
There was a problem hiding this comment.
https://stackoverflow.com/a/51594722
Seems like another option but is probably more obscure than your fix.
Deploying with
|
| Latest commit: |
e5daa1b
|
| Status: | ⚡️ Build in progress... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out we don't propagate the base url parameter properly with nested NPM scripts
Test Plan