This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Member assignment formatting #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
96f01f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8792e9c0.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-member-like.tools-8rn.pages.dev |
|
Could you add the updated metrics to the description please? |
Done |
This PR improves the formatting of static member assignment to match the formatting of static member expressions.
This PR improves the formatting of computed member assignment to match the formatting of computed member expressions.
MichaReiser
force-pushed
the
feat/member-like
branch
from
e63306b
to
96f01f5
Compare
ematipico
approved these changes
Aug 16, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the formatting of static and computed assignment expressions that Prettier formats the same as static/computed member expressions.
This is done by introducing new
JsAnyStaticMemberLikeandJsAnyComputedMemberLikeunion types that implement the common formatting logic.This PR also fixes the formatting of the special case
a[5]to match prettier's formatting.Test Plan
I manually compared Rome's and Prettier's output before updating the snapshots.
File Based Average Prettier Similarity: 79.75% ->79.91%
Line Based Average Prettier Similarity: 76.52% -> 76.58%