This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
test(rome_js_formatter): Ignore unsupported syntax from coverage #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4f09520
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://164f2676.tools-8rn.pages.dev |
| Branch Preview URL: | https://test-ignore-unsupported-synt.tools-8rn.pages.dev |
ematipico
approved these changes
Aug 16, 2022
MichaReiser
force-pushed
the
test/ignore-unsupported-syntax-from-coverage
branch
from
16ca8f4
to
622c840
Compare
Ignore test files with unsupported syntax (bind, tuple, record, ...) from the coverage report. The motivation of doing so is that we should focus on improving compatibility on syntax that we support. It's obvious that our formatting won't match Prettier's for syntax that the rome parser does not support. **File Based Average Prettier Similarity**: 79.75% -> 81.53% **Line Based Average Prettier Similarity**: 76.52% -> 78.29%
MichaReiser
force-pushed
the
test/ignore-unsupported-syntax-from-coverage
branch
from
622c840
to
4f09520
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore test files with unsupported syntax (bind, tuple, record, ...) from the coverage report.
The motivation of doing so is that we should focus on improving compatibility on syntax that we support. It's obvious that our formatting won't match Prettier's for syntax that the rome parser does not support.
File Based Average Prettier Similarity: 79.75% -> 81.53%
Line Based Average Prettier Similarity: 76.52% -> 78.29%