This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_formatter): Custom separator per Fill item
#3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors `Fill` to support different separator for every item rather than one uniform separator that separates all elements in the list. This is necessary to implement `fill` for array expressions where the separator should be a: * soft line break or space: if there are 0 - 1 line breaks before the node * empty line: if there are more than 1 new lines before the node.
ematipico
reviewed
Aug 29, 2022
Deploying with
|
| Latest commit: |
fcbddb2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e60bbfa.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-flat-ir.tools-8rn.pages.dev |
ematipico
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
Fillto support different separators for every item rather than one uniform separator that separates all elements in the list.This is necessary to implement
fillfor array expressions where the separator should be a:Used in #3126