This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_lsp): fix the calculation of offsets in the diff to LSP text edit conversion #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
approved these changes
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug in the code handling the conversion of text diff operations to LSP text edits, where the text positions where calculated as relative to the new revision of the text when they should have been offsets in the old revision instead.
Test Plan
This issue was not caught in the existing test because it replaced the sequence
oldwithnew, which happened to have the same length so there was no mismatch in offset between the two revisions. I've added an additional test case to cover this.