-
Notifications
You must be signed in to change notification settings - Fork 659
Conversation
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Also this file needs to be updated https://github.com/rome/tools/blob/main/crates/rome_diagnostics_categories/src/categories.rs |
@ematipico Do you mean the category keys? the links seem to be already pointing to |
Please @sebmck have a look at this PR. |
The URL of the rules have changed since we changed the website, and this is something we missed. (this is on us) This is the new URL of the rules: https://docs.rome.tools/lint/rules/usealttext/ If you go to the page, check one of the diagnostics and click the link rendered (the name of the rule), it points to an URL that returns 404. |
Here's the error returned by Netlify:
|
@ematipico Updated. please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you
* upstream/main: fix(ci): fix the release workflows for the stable release (rome#3583) Fix logo container margin Fix mobile docs regressions perf: End-to-end Linter and Formatter benchmarks (rome#3570) doc: VS Code extension (rome#3579) refactor(rome_cli): refactor the threading of parallel traversal to increase occupancy (rome#3577) [docs] Add navigation dropdown for docs (rome#3578) doc(rome_cli): Document `--files-max-size` option perf(rome_js_semantic): Use FX Hash function (rome#3565) fix(rome_js_analyzer): `noInvalidConstructorSuper` false positive for class expressions (rome#3561) Clean up mobile navigation doc(website): Run `cargo lintdoc` (rome#3567) doc: Fix install command Fix mobile code blocks Fix dark mode logo Update links Implement new website (rome#3556)
Summary
cargo lintdoc
output is dirty.Resolves:
cargo lintdoc
output is dirty #3566Test Plan
None