Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_cli): Respect formatter/linter enabled from configuration #3591

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

MichaReiser
Copy link
Contributor

Fixes an issue where rome ci ignored the formatter.enabled and linter.disabled configuration. The issue was that the CI defaulted to true when the --formater/linter-enabled options weren't specified.

Test Plan

The existing integration test didn't work because Rome doesn't check the formatting for files with lint/parse errors. I changed the integration test to a file that only has incorrect formatting.

Fixes an issue where `rome ci` ignored the `formatter.enabled` and `linter.disabled` configuration. The issue was that the CI defaulted to `true` when the `--formater/linter-enabled` options weren't specified.

## Test Plan

The reason why the existing integration test didn't work is that Rome doesn't check the formatting for files that have lint/parse errors. I changed the integration test to a file that only has incorrect formatting.
@MichaReiser MichaReiser added the A-CLI Area: CLI label Nov 8, 2022
@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit a3c34eb
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/636a7feabadd2e0008ec116a

@MichaReiser MichaReiser temporarily deployed to netlify-playground November 8, 2022 16:12 Inactive
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

@MichaReiser MichaReiser merged commit 903a3ed into main Nov 9, 2022
@MichaReiser MichaReiser deleted the fix/disable-formatter-linter branch November 9, 2022 07:30
@leops leops added this to the 10.0.1 milestone Nov 9, 2022
jeysal added a commit to jeysal/rometools that referenced this pull request Nov 9, 2022
* upstream/main:
  fix(rome_js_analyze): Verify method name of React API calls (rome#3619)
  benchmark: Add pprettier and dprint to benchmark (rome#3597)
  feat(vscode): display the version of the language server in the status bar (rome#3616)
  fix(rome_cli): correctly account for diff diagnostics in the printed diagnostics count (rome#3595)
  fix(rome_cli): Respect formatter/linter `enabled` from configuration (rome#3591)
  Remove dead styles
  [website] Add scroll-padding-top
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants