This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve the logic of jsx_reference_identifier_is_fragment #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
jsx_reference_identifier_is_fragmenthas a subtle logic bug that cause it to return false positive for symbol imported from"react"other thanFragment, for instanceStrictMode. I've modified the implementation to explicitly inspect the import nod and, check the source name of the imported symbol against "Fragment"Test Plan
I've added a few test case to ensure that
StrictModeandReact.StrictModedo not trigger thenoUselessFragmentsrule in various context