This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_lsp): improve the handling of UTF-8 and overflow errors in LineIndex
#3745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3733
This PR ensures the
LineIndex
utility (used to convert between theLineCol
andTextSize
representations of text positions within the language server) correctly accounts for UTF-8 character boundaries by properly converting between column numbers and byte offsets instead of directly reinterpreting each value kind as the other. I've also introduced additional error checking (especially in theline_col
method that's not failible just likeoffset
) to ensure that invalid text positions properly returnNone
rather than an invalid offset (or panic)Test Plan
I've added new test cases for
LineIndex
to check the result of bothoffset
andline_col
with various kinds of valid or invalid input